Re: [PATCH 1/2] ARM: dts: qcom: use qcom,gsi-loader for IPA

From: Konrad Dybcio
Date: Sat Dec 31 2022 - 06:52:32 EST




On 31.12.2022 01:27, Alex Elder wrote:
> Depending on the platform, either the modem or the AP must load GSI
> firmware for IPA before it can be used. To date, this has been
> indicated by the presence or absence of a "modem-init" property.
>
> That mechanism has been deprecated. Instead, we indicate how GSI
> firmware should be loaded by the value of the "qcom,gsi-loader"
> property.
>
> Update all ARM platforms that use IPA to use the "qcom,gsi-loader"
> property to specify how the GSI firmware is loaded.
>
> Update the affected nodes so the status property is last.
>
> Signed-off-by: Alex Elder <elder@xxxxxxxxxx>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Konrad
> arch/arm/boot/dts/qcom-sdx55-t55.dts | 4 ++--
> arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-sdx55-t55.dts b/arch/arm/boot/dts/qcom-sdx55-t55.dts
> index 7ed8feb99afbe..61ac5f54cd57d 100644
> --- a/arch/arm/boot/dts/qcom-sdx55-t55.dts
> +++ b/arch/arm/boot/dts/qcom-sdx55-t55.dts
> @@ -237,9 +237,9 @@ &blsp1_uart3 {
> };
>
> &ipa {
> - status = "okay";
> -
> + qcom,gsi-loader = "self";
> memory-region = <&ipa_fw_mem>;
> + status = "okay";
> };
>
> &qpic_bam {
> diff --git a/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts b/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts
> index ac8b4626ae9ac..c9c1f7da1261b 100644
> --- a/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts
> +++ b/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts
> @@ -237,9 +237,9 @@ &blsp1_uart3 {
> };
>
> &ipa {
> - status = "okay";
> -
> + qcom,gsi-loader = "self";
> memory-region = <&ipa_fw_mem>;
> + status = "okay";
> };
>
> &pcie0_phy {