Re: [PATCH] mtd: dataflash: remove duplicate SPI ID table

From: Miquel Raynal
Date: Mon Jan 02 2023 - 06:19:06 EST


On Thu, 2022-12-15 at 16:47:30 UTC, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> Building with -Werror=override-init revealds that two patches added
> the same device ID table to this driver:
>
> drivers/mtd/devices/mtd_dataflash.c:946:27: error: initialized field overwritten [-Werror=override-init]
> 946 | .id_table = dataflash_spi_ids,
> | ^~~~~~~~~~~~~~~~~
> drivers/mtd/devices/mtd_dataflash.c:946:27: note: (near initialization for 'dataflash_driver.id_table')
>
> Remove one of the copies.
>
> Fixes: 27a030e87292 ("mtd: dataflash: Add device-tree SPI IDs")
> Fixes: ac4f83482afb ("mtd: dataflash: Add SPI ID table")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.

Miquel