Re: [PATCH v3] selftest/vm: add mremap expand merge offset test

From: David Hildenbrand
Date: Mon Jan 02 2023 - 11:04:29 EST


- mremap_expand_merge(page_size);
+ maps_fp = fopen("/proc/self/maps", "r");
+ if (maps_fp == NULL) {
+ ksft_print_msg("Failed to read /proc/self/maps: %s\n", strerror(errno));
+ exit(KSFT_FAIL);
+ } else {

With the exit() in place, the else branch is implicit and the else can be dropped.

+ mremap_expand_merge(maps_fp, page_size);
+ mremap_expand_merge_offset(maps_fp, page_size);
+
+ fclose(maps_fp);
+ }
if (run_perf_tests) {
ksft_print_msg("\n%s\n",

Thanks!

Acked-by: David Hildenbrand <david@xxxxxxxxxx>

--
Thanks,

David / dhildenb