Re: [PATCH 13/14] drm/panel-sony-tulip-truly-nt35521: Drop custom DSI write macro
From: Sam Ravnborg
Date: Mon Jan 02 2023 - 13:51:56 EST
Hi Javier,
On Wed, Dec 28, 2022 at 02:47:56AM +0100, Javier Martinez Canillas wrote:
> There is a macro for this already in the <drm/drm_mipi_dsi.h> header, use
> that instead and delete the custom DSI write macro defined in the driver.
>
> Signed-off-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
> ---
>
> .../panel/panel-sony-tulip-truly-nt35521.c | 348 +++++++++---------
> 1 file changed, 170 insertions(+), 178 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-sony-tulip-truly-nt35521.c b/drivers/gpu/drm/panel/panel-sony-tulip-truly-nt35521.c
> index fa9be3c299c0..a0661576acff 100644
> --- a/drivers/gpu/drm/panel/panel-sony-tulip-truly-nt35521.c
> +++ b/drivers/gpu/drm/panel/panel-sony-tulip-truly-nt35521.c
> @@ -33,14 +33,6 @@ struct truly_nt35521 *to_truly_nt35521(struct drm_panel *panel)
> return container_of(panel, struct truly_nt35521, panel);
> }
>
> -#define dsi_generic_write_seq(dsi, seq...) do { \
> - static const u8 d[] = { seq }; \
> - int ret; \
> - ret = mipi_dsi_generic_write(dsi, d, ARRAY_SIZE(d)); \
> - if (ret < 0) \
> - return ret; \
> - } while (0)
> -
> static void truly_nt35521_reset(struct truly_nt35521 *ctx)
> {
> gpiod_set_value_cansleep(ctx->reset_gpio, 1);
> @@ -59,200 +51,200 @@ static int truly_nt35521_on(struct truly_nt35521 *ctx)
>
> dsi->mode_flags |= MIPI_DSI_MODE_LPM;
>
> - dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x00);
> - dsi_generic_write_seq(dsi, 0xff, 0xaa, 0x55, 0xa5, 0x80);
> - dsi_generic_write_seq(dsi, 0x6f, 0x11, 0x00);
> - dsi_generic_write_seq(dsi, 0xf7, 0x20, 0x00);
> - dsi_generic_write_seq(dsi, 0x6f, 0x01);
> - dsi_generic_write_seq(dsi, 0xb1, 0x21);
> - dsi_generic_write_seq(dsi, 0xbd, 0x01, 0xa0, 0x10, 0x08, 0x01);
> - dsi_generic_write_seq(dsi, 0xb8, 0x01, 0x02, 0x0c, 0x02);
> - dsi_generic_write_seq(dsi, 0xbb, 0x11, 0x11);
> - dsi_generic_write_seq(dsi, 0xbc, 0x00, 0x00);
> - dsi_generic_write_seq(dsi, 0xb6, 0x02);
> - dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x01);
> - dsi_generic_write_seq(dsi, 0xb0, 0x09, 0x09);
> - dsi_generic_write_seq(dsi, 0xb1, 0x09, 0x09);
> - dsi_generic_write_seq(dsi, 0xbc, 0x8c, 0x00);
> - dsi_generic_write_seq(dsi, 0xbd, 0x8c, 0x00);
> - dsi_generic_write_seq(dsi, 0xca, 0x00);
> - dsi_generic_write_seq(dsi, 0xc0, 0x04);
> - dsi_generic_write_seq(dsi, 0xbe, 0xb5);
> - dsi_generic_write_seq(dsi, 0xb3, 0x35, 0x35);
> - dsi_generic_write_seq(dsi, 0xb4, 0x25, 0x25);
> - dsi_generic_write_seq(dsi, 0xb9, 0x43, 0x43);
> - dsi_generic_write_seq(dsi, 0xba, 0x24, 0x24);
> - dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x02);
> - dsi_generic_write_seq(dsi, 0xee, 0x03);
> - dsi_generic_write_seq(dsi, 0xb0,
> + mipi_dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xff, 0xaa, 0x55, 0xa5, 0x80);
> + mipi_dsi_generic_write_seq(dsi, 0x6f, 0x11, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xf7, 0x20, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0x6f, 0x01);
> + mipi_dsi_generic_write_seq(dsi, 0xb1, 0x21);
> + mipi_dsi_generic_write_seq(dsi, 0xbd, 0x01, 0xa0, 0x10, 0x08, 0x01);
> + mipi_dsi_generic_write_seq(dsi, 0xb8, 0x01, 0x02, 0x0c, 0x02);
> + mipi_dsi_generic_write_seq(dsi, 0xbb, 0x11, 0x11);
> + mipi_dsi_generic_write_seq(dsi, 0xbc, 0x00, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xb6, 0x02);
> + mipi_dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x01);
> + mipi_dsi_generic_write_seq(dsi, 0xb0, 0x09, 0x09);
> + mipi_dsi_generic_write_seq(dsi, 0xb1, 0x09, 0x09);
> + mipi_dsi_generic_write_seq(dsi, 0xbc, 0x8c, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xbd, 0x8c, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xca, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xc0, 0x04);
> + mipi_dsi_generic_write_seq(dsi, 0xbe, 0xb5);
> + mipi_dsi_generic_write_seq(dsi, 0xb3, 0x35, 0x35);
> + mipi_dsi_generic_write_seq(dsi, 0xb4, 0x25, 0x25);
> + mipi_dsi_generic_write_seq(dsi, 0xb9, 0x43, 0x43);
> + mipi_dsi_generic_write_seq(dsi, 0xba, 0x24, 0x24);
> + mipi_dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x02);
> + mipi_dsi_generic_write_seq(dsi, 0xee, 0x03);
> + mipi_dsi_generic_write_seq(dsi, 0xb0,
> 0x00, 0xb2, 0x00, 0xb3, 0x00, 0xb6, 0x00, 0xc3,
> 0x00, 0xce, 0x00, 0xe1, 0x00, 0xf3, 0x01, 0x11);
Fix indent - here and elsewhere.
With this fixed:
Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> - dsi_generic_write_seq(dsi, 0xb1,
> + mipi_dsi_generic_write_seq(dsi, 0xb1,
> 0x01, 0x2e, 0x01, 0x5c, 0x01, 0x82, 0x01, 0xc3,
> 0x01, 0xfe, 0x02, 0x00, 0x02, 0x37, 0x02, 0x77);
> - dsi_generic_write_seq(dsi, 0xb2,
> + mipi_dsi_generic_write_seq(dsi, 0xb2,
> 0x02, 0xa1, 0x02, 0xd7, 0x02, 0xfe, 0x03, 0x2c,
> 0x03, 0x4b, 0x03, 0x63, 0x03, 0x8f, 0x03, 0x90);
> - dsi_generic_write_seq(dsi, 0xb3, 0x03, 0x96, 0x03, 0x98);
> - dsi_generic_write_seq(dsi, 0xb4,
> + mipi_dsi_generic_write_seq(dsi, 0xb3, 0x03, 0x96, 0x03, 0x98);
> + mipi_dsi_generic_write_seq(dsi, 0xb4,
> 0x00, 0x81, 0x00, 0x8b, 0x00, 0x9c, 0x00, 0xa9,
> 0x00, 0xb5, 0x00, 0xcb, 0x00, 0xdf, 0x01, 0x02);
> - dsi_generic_write_seq(dsi, 0xb5,
> + mipi_dsi_generic_write_seq(dsi, 0xb5,
> 0x01, 0x1f, 0x01, 0x51, 0x01, 0x7a, 0x01, 0xbf,
> 0x01, 0xfa, 0x01, 0xfc, 0x02, 0x34, 0x02, 0x76);
> - dsi_generic_write_seq(dsi, 0xb6,
> + mipi_dsi_generic_write_seq(dsi, 0xb6,
> 0x02, 0x9f, 0x02, 0xd7, 0x02, 0xfc, 0x03, 0x2c,
> 0x03, 0x4a, 0x03, 0x63, 0x03, 0x8f, 0x03, 0xa2);
> - dsi_generic_write_seq(dsi, 0xb7, 0x03, 0xb8, 0x03, 0xba);
> - dsi_generic_write_seq(dsi, 0xb8,
> + mipi_dsi_generic_write_seq(dsi, 0xb7, 0x03, 0xb8, 0x03, 0xba);
> + mipi_dsi_generic_write_seq(dsi, 0xb8,
> 0x00, 0x01, 0x00, 0x02, 0x00, 0x0e, 0x00, 0x2a,
> 0x00, 0x41, 0x00, 0x67, 0x00, 0x87, 0x00, 0xb9);
> - dsi_generic_write_seq(dsi, 0xb9,
> + mipi_dsi_generic_write_seq(dsi, 0xb9,
> 0x00, 0xe2, 0x01, 0x22, 0x01, 0x54, 0x01, 0xa3,
> 0x01, 0xe6, 0x01, 0xe7, 0x02, 0x24, 0x02, 0x67);
> - dsi_generic_write_seq(dsi, 0xba,
> + mipi_dsi_generic_write_seq(dsi, 0xba,
> 0x02, 0x93, 0x02, 0xcd, 0x02, 0xf6, 0x03, 0x31,
> 0x03, 0x6c, 0x03, 0xe9, 0x03, 0xef, 0x03, 0xf4);
> - dsi_generic_write_seq(dsi, 0xbb, 0x03, 0xf6, 0x03, 0xf7);
> - dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x03);
> - dsi_generic_write_seq(dsi, 0xb0, 0x22, 0x00);
> - dsi_generic_write_seq(dsi, 0xb1, 0x22, 0x00);
> - dsi_generic_write_seq(dsi, 0xb2, 0x05, 0x00, 0x60, 0x00, 0x00);
> - dsi_generic_write_seq(dsi, 0xb3, 0x05, 0x00, 0x60, 0x00, 0x00);
> - dsi_generic_write_seq(dsi, 0xb4, 0x05, 0x00, 0x60, 0x00, 0x00);
> - dsi_generic_write_seq(dsi, 0xb5, 0x05, 0x00, 0x60, 0x00, 0x00);
> - dsi_generic_write_seq(dsi, 0xba, 0x53, 0x00, 0x60, 0x00, 0x00);
> - dsi_generic_write_seq(dsi, 0xbb, 0x53, 0x00, 0x60, 0x00, 0x00);
> - dsi_generic_write_seq(dsi, 0xbc, 0x53, 0x00, 0x60, 0x00, 0x00);
> - dsi_generic_write_seq(dsi, 0xbd, 0x53, 0x00, 0x60, 0x00, 0x00);
> - dsi_generic_write_seq(dsi, 0xc0, 0x00, 0x34, 0x00, 0x00);
> - dsi_generic_write_seq(dsi, 0xc1, 0x00, 0x00, 0x34, 0x00);
> - dsi_generic_write_seq(dsi, 0xc2, 0x00, 0x00, 0x34, 0x00);
> - dsi_generic_write_seq(dsi, 0xc3, 0x00, 0x00, 0x34, 0x00);
> - dsi_generic_write_seq(dsi, 0xc4, 0x60);
> - dsi_generic_write_seq(dsi, 0xc5, 0xc0);
> - dsi_generic_write_seq(dsi, 0xc6, 0x00);
> - dsi_generic_write_seq(dsi, 0xc7, 0x00);
> - dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x05);
> - dsi_generic_write_seq(dsi, 0xb0, 0x17, 0x06);
> - dsi_generic_write_seq(dsi, 0xb1, 0x17, 0x06);
> - dsi_generic_write_seq(dsi, 0xb2, 0x17, 0x06);
> - dsi_generic_write_seq(dsi, 0xb3, 0x17, 0x06);
> - dsi_generic_write_seq(dsi, 0xb4, 0x17, 0x06);
> - dsi_generic_write_seq(dsi, 0xb5, 0x17, 0x06);
> - dsi_generic_write_seq(dsi, 0xb6, 0x17, 0x06);
> - dsi_generic_write_seq(dsi, 0xb7, 0x17, 0x06);
> - dsi_generic_write_seq(dsi, 0xb8, 0x00);
> - dsi_generic_write_seq(dsi, 0xb9, 0x00, 0x03);
> - dsi_generic_write_seq(dsi, 0xba, 0x00, 0x00);
> - dsi_generic_write_seq(dsi, 0xbb, 0x02, 0x03);
> - dsi_generic_write_seq(dsi, 0xbc, 0x02, 0x03);
> - dsi_generic_write_seq(dsi, 0xbd, 0x03, 0x03, 0x00, 0x03, 0x03);
> - dsi_generic_write_seq(dsi, 0xc0, 0x0b);
> - dsi_generic_write_seq(dsi, 0xc1, 0x09);
> - dsi_generic_write_seq(dsi, 0xc2, 0xa6);
> - dsi_generic_write_seq(dsi, 0xc3, 0x05);
> - dsi_generic_write_seq(dsi, 0xc4, 0x00);
> - dsi_generic_write_seq(dsi, 0xc5, 0x02);
> - dsi_generic_write_seq(dsi, 0xc6, 0x22);
> - dsi_generic_write_seq(dsi, 0xc7, 0x03);
> - dsi_generic_write_seq(dsi, 0xc8, 0x07, 0x20);
> - dsi_generic_write_seq(dsi, 0xc9, 0x03, 0x20);
> - dsi_generic_write_seq(dsi, 0xca, 0x01, 0x60);
> - dsi_generic_write_seq(dsi, 0xcb, 0x01, 0x60);
> - dsi_generic_write_seq(dsi, 0xcc, 0x00, 0x00, 0x02);
> - dsi_generic_write_seq(dsi, 0xcd, 0x00, 0x00, 0x02);
> - dsi_generic_write_seq(dsi, 0xce, 0x00, 0x00, 0x02);
> - dsi_generic_write_seq(dsi, 0xcf, 0x00, 0x00, 0x02);
> - dsi_generic_write_seq(dsi, 0xd1, 0x00, 0x05, 0x01, 0x07, 0x10);
> - dsi_generic_write_seq(dsi, 0xd2, 0x10, 0x05, 0x05, 0x03, 0x10);
> - dsi_generic_write_seq(dsi, 0xd3, 0x20, 0x00, 0x43, 0x07, 0x10);
> - dsi_generic_write_seq(dsi, 0xd4, 0x30, 0x00, 0x43, 0x07, 0x10);
> - dsi_generic_write_seq(dsi, 0xd0,
> + mipi_dsi_generic_write_seq(dsi, 0xbb, 0x03, 0xf6, 0x03, 0xf7);
> + mipi_dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x03);
> + mipi_dsi_generic_write_seq(dsi, 0xb0, 0x22, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xb1, 0x22, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xb2, 0x05, 0x00, 0x60, 0x00, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xb3, 0x05, 0x00, 0x60, 0x00, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xb4, 0x05, 0x00, 0x60, 0x00, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xb5, 0x05, 0x00, 0x60, 0x00, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xba, 0x53, 0x00, 0x60, 0x00, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xbb, 0x53, 0x00, 0x60, 0x00, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xbc, 0x53, 0x00, 0x60, 0x00, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xbd, 0x53, 0x00, 0x60, 0x00, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xc0, 0x00, 0x34, 0x00, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xc1, 0x00, 0x00, 0x34, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xc2, 0x00, 0x00, 0x34, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xc3, 0x00, 0x00, 0x34, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xc4, 0x60);
> + mipi_dsi_generic_write_seq(dsi, 0xc5, 0xc0);
> + mipi_dsi_generic_write_seq(dsi, 0xc6, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xc7, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x05);
> + mipi_dsi_generic_write_seq(dsi, 0xb0, 0x17, 0x06);
> + mipi_dsi_generic_write_seq(dsi, 0xb1, 0x17, 0x06);
> + mipi_dsi_generic_write_seq(dsi, 0xb2, 0x17, 0x06);
> + mipi_dsi_generic_write_seq(dsi, 0xb3, 0x17, 0x06);
> + mipi_dsi_generic_write_seq(dsi, 0xb4, 0x17, 0x06);
> + mipi_dsi_generic_write_seq(dsi, 0xb5, 0x17, 0x06);
> + mipi_dsi_generic_write_seq(dsi, 0xb6, 0x17, 0x06);
> + mipi_dsi_generic_write_seq(dsi, 0xb7, 0x17, 0x06);
> + mipi_dsi_generic_write_seq(dsi, 0xb8, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xb9, 0x00, 0x03);
> + mipi_dsi_generic_write_seq(dsi, 0xba, 0x00, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xbb, 0x02, 0x03);
> + mipi_dsi_generic_write_seq(dsi, 0xbc, 0x02, 0x03);
> + mipi_dsi_generic_write_seq(dsi, 0xbd, 0x03, 0x03, 0x00, 0x03, 0x03);
> + mipi_dsi_generic_write_seq(dsi, 0xc0, 0x0b);
> + mipi_dsi_generic_write_seq(dsi, 0xc1, 0x09);
> + mipi_dsi_generic_write_seq(dsi, 0xc2, 0xa6);
> + mipi_dsi_generic_write_seq(dsi, 0xc3, 0x05);
> + mipi_dsi_generic_write_seq(dsi, 0xc4, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xc5, 0x02);
> + mipi_dsi_generic_write_seq(dsi, 0xc6, 0x22);
> + mipi_dsi_generic_write_seq(dsi, 0xc7, 0x03);
> + mipi_dsi_generic_write_seq(dsi, 0xc8, 0x07, 0x20);
> + mipi_dsi_generic_write_seq(dsi, 0xc9, 0x03, 0x20);
> + mipi_dsi_generic_write_seq(dsi, 0xca, 0x01, 0x60);
> + mipi_dsi_generic_write_seq(dsi, 0xcb, 0x01, 0x60);
> + mipi_dsi_generic_write_seq(dsi, 0xcc, 0x00, 0x00, 0x02);
> + mipi_dsi_generic_write_seq(dsi, 0xcd, 0x00, 0x00, 0x02);
> + mipi_dsi_generic_write_seq(dsi, 0xce, 0x00, 0x00, 0x02);
> + mipi_dsi_generic_write_seq(dsi, 0xcf, 0x00, 0x00, 0x02);
> + mipi_dsi_generic_write_seq(dsi, 0xd1, 0x00, 0x05, 0x01, 0x07, 0x10);
> + mipi_dsi_generic_write_seq(dsi, 0xd2, 0x10, 0x05, 0x05, 0x03, 0x10);
> + mipi_dsi_generic_write_seq(dsi, 0xd3, 0x20, 0x00, 0x43, 0x07, 0x10);
> + mipi_dsi_generic_write_seq(dsi, 0xd4, 0x30, 0x00, 0x43, 0x07, 0x10);
> + mipi_dsi_generic_write_seq(dsi, 0xd0,
> 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00);
> - dsi_generic_write_seq(dsi, 0xd5,
> + mipi_dsi_generic_write_seq(dsi, 0xd5,
> 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> 0x00, 0x00, 0x00);
> - dsi_generic_write_seq(dsi, 0xd6,
> + mipi_dsi_generic_write_seq(dsi, 0xd6,
> 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> 0x00, 0x00, 0x00);
> - dsi_generic_write_seq(dsi, 0xd7,
> + mipi_dsi_generic_write_seq(dsi, 0xd7,
> 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> 0x00, 0x00, 0x00);
> - dsi_generic_write_seq(dsi, 0xd8, 0x00, 0x00, 0x00, 0x00, 0x00);
> - dsi_generic_write_seq(dsi, 0xe5, 0x06);
> - dsi_generic_write_seq(dsi, 0xe6, 0x06);
> - dsi_generic_write_seq(dsi, 0xe7, 0x00);
> - dsi_generic_write_seq(dsi, 0xe8, 0x06);
> - dsi_generic_write_seq(dsi, 0xe9, 0x06);
> - dsi_generic_write_seq(dsi, 0xea, 0x06);
> - dsi_generic_write_seq(dsi, 0xeb, 0x00);
> - dsi_generic_write_seq(dsi, 0xec, 0x00);
> - dsi_generic_write_seq(dsi, 0xed, 0x30);
> - dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x06);
> - dsi_generic_write_seq(dsi, 0xb0, 0x31, 0x31);
> - dsi_generic_write_seq(dsi, 0xb1, 0x31, 0x31);
> - dsi_generic_write_seq(dsi, 0xb2, 0x2d, 0x2e);
> - dsi_generic_write_seq(dsi, 0xb3, 0x31, 0x34);
> - dsi_generic_write_seq(dsi, 0xb4, 0x29, 0x2a);
> - dsi_generic_write_seq(dsi, 0xb5, 0x12, 0x10);
> - dsi_generic_write_seq(dsi, 0xb6, 0x18, 0x16);
> - dsi_generic_write_seq(dsi, 0xb7, 0x00, 0x02);
> - dsi_generic_write_seq(dsi, 0xb8, 0x08, 0x31);
> - dsi_generic_write_seq(dsi, 0xb9, 0x31, 0x31);
> - dsi_generic_write_seq(dsi, 0xba, 0x31, 0x31);
> - dsi_generic_write_seq(dsi, 0xbb, 0x31, 0x08);
> - dsi_generic_write_seq(dsi, 0xbc, 0x03, 0x01);
> - dsi_generic_write_seq(dsi, 0xbd, 0x17, 0x19);
> - dsi_generic_write_seq(dsi, 0xbe, 0x11, 0x13);
> - dsi_generic_write_seq(dsi, 0xbf, 0x2a, 0x29);
> - dsi_generic_write_seq(dsi, 0xc0, 0x34, 0x31);
> - dsi_generic_write_seq(dsi, 0xc1, 0x2e, 0x2d);
> - dsi_generic_write_seq(dsi, 0xc2, 0x31, 0x31);
> - dsi_generic_write_seq(dsi, 0xc3, 0x31, 0x31);
> - dsi_generic_write_seq(dsi, 0xc4, 0x31, 0x31);
> - dsi_generic_write_seq(dsi, 0xc5, 0x31, 0x31);
> - dsi_generic_write_seq(dsi, 0xc6, 0x2e, 0x2d);
> - dsi_generic_write_seq(dsi, 0xc7, 0x31, 0x34);
> - dsi_generic_write_seq(dsi, 0xc8, 0x29, 0x2a);
> - dsi_generic_write_seq(dsi, 0xc9, 0x17, 0x19);
> - dsi_generic_write_seq(dsi, 0xca, 0x11, 0x13);
> - dsi_generic_write_seq(dsi, 0xcb, 0x03, 0x01);
> - dsi_generic_write_seq(dsi, 0xcc, 0x08, 0x31);
> - dsi_generic_write_seq(dsi, 0xcd, 0x31, 0x31);
> - dsi_generic_write_seq(dsi, 0xce, 0x31, 0x31);
> - dsi_generic_write_seq(dsi, 0xcf, 0x31, 0x08);
> - dsi_generic_write_seq(dsi, 0xd0, 0x00, 0x02);
> - dsi_generic_write_seq(dsi, 0xd1, 0x12, 0x10);
> - dsi_generic_write_seq(dsi, 0xd2, 0x18, 0x16);
> - dsi_generic_write_seq(dsi, 0xd3, 0x2a, 0x29);
> - dsi_generic_write_seq(dsi, 0xd4, 0x34, 0x31);
> - dsi_generic_write_seq(dsi, 0xd5, 0x2d, 0x2e);
> - dsi_generic_write_seq(dsi, 0xd6, 0x31, 0x31);
> - dsi_generic_write_seq(dsi, 0xd7, 0x31, 0x31);
> - dsi_generic_write_seq(dsi, 0xe5, 0x31, 0x31);
> - dsi_generic_write_seq(dsi, 0xe6, 0x31, 0x31);
> - dsi_generic_write_seq(dsi, 0xd8, 0x00, 0x00, 0x00, 0x00, 0x00);
> - dsi_generic_write_seq(dsi, 0xd9, 0x00, 0x00, 0x00, 0x00, 0x00);
> - dsi_generic_write_seq(dsi, 0xe7, 0x00);
> - dsi_generic_write_seq(dsi, 0x6f, 0x02);
> - dsi_generic_write_seq(dsi, 0xf7, 0x47);
> - dsi_generic_write_seq(dsi, 0x6f, 0x0a);
> - dsi_generic_write_seq(dsi, 0xf7, 0x02);
> - dsi_generic_write_seq(dsi, 0x6f, 0x17);
> - dsi_generic_write_seq(dsi, 0xf4, 0x60);
> - dsi_generic_write_seq(dsi, 0x6f, 0x01);
> - dsi_generic_write_seq(dsi, 0xf9, 0x46);
> - dsi_generic_write_seq(dsi, 0x6f, 0x11);
> - dsi_generic_write_seq(dsi, 0xf3, 0x01);
> - dsi_generic_write_seq(dsi, 0x35, 0x00);
> - dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x00);
> - dsi_generic_write_seq(dsi, 0xd9, 0x02, 0x03, 0x00);
> - dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x00, 0x00);
> - dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x00);
> - dsi_generic_write_seq(dsi, 0xb1, 0x6c, 0x21);
> - dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x00, 0x00);
> - dsi_generic_write_seq(dsi, 0x35, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xd8, 0x00, 0x00, 0x00, 0x00, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xe5, 0x06);
> + mipi_dsi_generic_write_seq(dsi, 0xe6, 0x06);
> + mipi_dsi_generic_write_seq(dsi, 0xe7, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xe8, 0x06);
> + mipi_dsi_generic_write_seq(dsi, 0xe9, 0x06);
> + mipi_dsi_generic_write_seq(dsi, 0xea, 0x06);
> + mipi_dsi_generic_write_seq(dsi, 0xeb, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xec, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xed, 0x30);
> + mipi_dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x06);
> + mipi_dsi_generic_write_seq(dsi, 0xb0, 0x31, 0x31);
> + mipi_dsi_generic_write_seq(dsi, 0xb1, 0x31, 0x31);
> + mipi_dsi_generic_write_seq(dsi, 0xb2, 0x2d, 0x2e);
> + mipi_dsi_generic_write_seq(dsi, 0xb3, 0x31, 0x34);
> + mipi_dsi_generic_write_seq(dsi, 0xb4, 0x29, 0x2a);
> + mipi_dsi_generic_write_seq(dsi, 0xb5, 0x12, 0x10);
> + mipi_dsi_generic_write_seq(dsi, 0xb6, 0x18, 0x16);
> + mipi_dsi_generic_write_seq(dsi, 0xb7, 0x00, 0x02);
> + mipi_dsi_generic_write_seq(dsi, 0xb8, 0x08, 0x31);
> + mipi_dsi_generic_write_seq(dsi, 0xb9, 0x31, 0x31);
> + mipi_dsi_generic_write_seq(dsi, 0xba, 0x31, 0x31);
> + mipi_dsi_generic_write_seq(dsi, 0xbb, 0x31, 0x08);
> + mipi_dsi_generic_write_seq(dsi, 0xbc, 0x03, 0x01);
> + mipi_dsi_generic_write_seq(dsi, 0xbd, 0x17, 0x19);
> + mipi_dsi_generic_write_seq(dsi, 0xbe, 0x11, 0x13);
> + mipi_dsi_generic_write_seq(dsi, 0xbf, 0x2a, 0x29);
> + mipi_dsi_generic_write_seq(dsi, 0xc0, 0x34, 0x31);
> + mipi_dsi_generic_write_seq(dsi, 0xc1, 0x2e, 0x2d);
> + mipi_dsi_generic_write_seq(dsi, 0xc2, 0x31, 0x31);
> + mipi_dsi_generic_write_seq(dsi, 0xc3, 0x31, 0x31);
> + mipi_dsi_generic_write_seq(dsi, 0xc4, 0x31, 0x31);
> + mipi_dsi_generic_write_seq(dsi, 0xc5, 0x31, 0x31);
> + mipi_dsi_generic_write_seq(dsi, 0xc6, 0x2e, 0x2d);
> + mipi_dsi_generic_write_seq(dsi, 0xc7, 0x31, 0x34);
> + mipi_dsi_generic_write_seq(dsi, 0xc8, 0x29, 0x2a);
> + mipi_dsi_generic_write_seq(dsi, 0xc9, 0x17, 0x19);
> + mipi_dsi_generic_write_seq(dsi, 0xca, 0x11, 0x13);
> + mipi_dsi_generic_write_seq(dsi, 0xcb, 0x03, 0x01);
> + mipi_dsi_generic_write_seq(dsi, 0xcc, 0x08, 0x31);
> + mipi_dsi_generic_write_seq(dsi, 0xcd, 0x31, 0x31);
> + mipi_dsi_generic_write_seq(dsi, 0xce, 0x31, 0x31);
> + mipi_dsi_generic_write_seq(dsi, 0xcf, 0x31, 0x08);
> + mipi_dsi_generic_write_seq(dsi, 0xd0, 0x00, 0x02);
> + mipi_dsi_generic_write_seq(dsi, 0xd1, 0x12, 0x10);
> + mipi_dsi_generic_write_seq(dsi, 0xd2, 0x18, 0x16);
> + mipi_dsi_generic_write_seq(dsi, 0xd3, 0x2a, 0x29);
> + mipi_dsi_generic_write_seq(dsi, 0xd4, 0x34, 0x31);
> + mipi_dsi_generic_write_seq(dsi, 0xd5, 0x2d, 0x2e);
> + mipi_dsi_generic_write_seq(dsi, 0xd6, 0x31, 0x31);
> + mipi_dsi_generic_write_seq(dsi, 0xd7, 0x31, 0x31);
> + mipi_dsi_generic_write_seq(dsi, 0xe5, 0x31, 0x31);
> + mipi_dsi_generic_write_seq(dsi, 0xe6, 0x31, 0x31);
> + mipi_dsi_generic_write_seq(dsi, 0xd8, 0x00, 0x00, 0x00, 0x00, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xd9, 0x00, 0x00, 0x00, 0x00, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xe7, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0x6f, 0x02);
> + mipi_dsi_generic_write_seq(dsi, 0xf7, 0x47);
> + mipi_dsi_generic_write_seq(dsi, 0x6f, 0x0a);
> + mipi_dsi_generic_write_seq(dsi, 0xf7, 0x02);
> + mipi_dsi_generic_write_seq(dsi, 0x6f, 0x17);
> + mipi_dsi_generic_write_seq(dsi, 0xf4, 0x60);
> + mipi_dsi_generic_write_seq(dsi, 0x6f, 0x01);
> + mipi_dsi_generic_write_seq(dsi, 0xf9, 0x46);
> + mipi_dsi_generic_write_seq(dsi, 0x6f, 0x11);
> + mipi_dsi_generic_write_seq(dsi, 0xf3, 0x01);
> + mipi_dsi_generic_write_seq(dsi, 0x35, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xd9, 0x02, 0x03, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x00, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0xb1, 0x6c, 0x21);
> + mipi_dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x00, 0x00);
> + mipi_dsi_generic_write_seq(dsi, 0x35, 0x00);
>
> ret = mipi_dsi_dcs_exit_sleep_mode(dsi);
> if (ret < 0) {
> @@ -268,7 +260,7 @@ static int truly_nt35521_on(struct truly_nt35521 *ctx)
> }
> usleep_range(1000, 2000);
>
> - dsi_generic_write_seq(dsi, 0x53, 0x24);
> + mipi_dsi_generic_write_seq(dsi, 0x53, 0x24);
>
> return 0;
> }
> --
> 2.38.1