Re: [PATCH 14/14] drm/panel-xinpeng-xpp055c272: Drop custom DSI write macro

[Javier Martinez Canillas]

On 1/2/23 19:53, Sam Ravnborg wrote:

[...]

>>  }
>>  
>> -#define dsi_generic_write_seq(dsi, cmd, seq...) do {			\
>> -		static const u8 b[] = { cmd, seq };			\
>> -		int ret;						\
>> -		ret = mipi_dsi_dcs_write_buffer(dsi, b, ARRAY_SIZE(b));	\
> Notice that this is *dcs*
>

I missed that! Thanks a lot for catching this inconsistency in the naming.

[...]

>> -	dsi_generic_write_seq(dsi, XPP055C272_CMD_SETEXTC, 0xf1, 0x12, 0x83);
>> -	dsi_generic_write_seq(dsi, XPP055C272_CMD_SETMIPI,
>> +	mipi_dsi_generic_write_seq(dsi, XPP055C272_CMD_SETEXTC, 0xf1, 0x12, 0x83);
> This is wrong - here you should use mipi_dsi_dcs_write_seq()
> Likewise for the rest of the file.
>

Agreed.

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat