RE: [PATCH v4 1/4] crypto: aspeed: Add ACRY RSA driver

[Neal Liu]

> -----Original Message-----
> From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> Sent: Friday, December 30, 2022 4:29 PM
> To: Neal Liu <neal_liu@xxxxxxxxxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@xxxxxxxxxx>; Joel Stanley <joel@xxxxxxxxx>; Andrew
> Jeffery <andrew@xxxxxxxx>; David S . Miller <davem@xxxxxxxxxxxxx>;
> ChiaWei Wang <chiawei_wang@xxxxxxxxxxxxxx>;
> devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> linux-aspeed@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> linux-crypto@xxxxxxxxxxxxxxx; Christoph Hellwig <hch@xxxxxxxxxxxxx>
> Subject: Re: [PATCH v4 1/4] crypto: aspeed: Add ACRY RSA driver
> 
> On Wed, Dec 14, 2022 at 03:01:11PM +0800, Neal Liu wrote:
> >
> > +static u8 *aspeed_rsa_key_copy(u8 *src, size_t len) {
> > +	return kmemdup(src, len, GFP_DMA | GFP_KERNEL);
> 
> Please explain why you are using GFP_DMA.

Looks like it's unnecessary. I'll remove it.
Thanks.

> Thanks,
> --
> Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page:
> http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt