Re: [PATCH 1/2] drm/panel-edp: fix name for IVO product id 854b
From: Johan Hovold
Date: Tue Jan 03 2023 - 02:58:46 EST
On Tue, Jan 03, 2023 at 12:36:51AM +0200, Abel Vesa wrote:
> On 23-01-02 09:21:40, Johan Hovold wrote:
> > On Sun, Jan 01, 2023 at 10:58:42PM -0600, Steev Klimaszewski wrote:
> > > On Sat, Dec 31, 2022 at 8:27 AM Abel Vesa <abel.vesa@xxxxxxxxxx> wrote:
> > > >
> > > > The actual name is R133NW4K-R0.
> > > >
> > > > Fixes: 0f9fa5f58c784 ("drm/panel-edp: add IVO M133NW4J-R3 panel entry")
> > > > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
> > > > ---
> > > >
> > > > Assuming the information from here is correct:
> > > > https://raw.githubusercontent.com/linuxhw/EDID/master/DigitalDisplay.md
> > > Thanks for this - when I was looking for the panel, I simply went with
> > > what I found on panel-look.
> >
> > Did you check what string your panel reports? For example, using
> > something like:
> >
> > # strings /sys/class/drm/card0-eDP-1/edid
> > ...
> > B133UAN02.1
>
> Mine shows: M133NW4J R3
>
> But since both R0 and R3 have the same product ID, I decided to drop the
> revision part, otherwise we would need to add a second entry with the
> only difference between them being the revision part (Rx). This is what
> I did in patch #2.
Makes sense. Thanks for confirming.
Johan