Re: [PATCH v2] wifi: ath11k: Fix memory leak in ath11k_peer_rx_frag_setup

From: Leon Romanovsky
Date: Tue Jan 03 2023 - 04:22:04 EST


On Mon, Jan 02, 2023 at 12:11:42PM +0400, Miaoqian Lin wrote:
> crypto_alloc_shash() allocates resources, which should be released by
> crypto_free_shash(). When ath11k_peer_find() fails, there has memory
> leak. Add missing crypto_free_shash() to fix this.
>
> Fixes: 243874c64c81 ("ath11k: handle RX fragments")
> Signed-off-by: Miaoqian Lin <linmq006@xxxxxxxxx>
> ---
> change in v2:
> - add crypto_free_shash() in the error path instead of move
> crypto_alloc_shash().
> ---
> drivers/net/wireless/ath/ath11k/dp_rx.c | 1 +
> 1 file changed, 1 insertion(+)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxx>