Hi Miaoqian,
On Thu, Dec 29, 2022 at 8:53 AM Miaoqian Lin <linmq006@xxxxxxxxx> wrote:
kstrdup() return newly allocated copy of the string.Thanks for your patch!
Call kfree() to release the memory when after use.
Fixes: 49da7e64f33e ("High Performance UML Vector Network Driver")
Signed-off-by: Miaoqian Lin <linmq006@xxxxxxxxx>
--- a/arch/um/drivers/vector_kern.cAre you sure the memory pointed to by "params" is no longer used?
+++ b/arch/um/drivers/vector_kern.c
@@ -765,6 +765,7 @@ static int vector_config(char *str, char **error_out)
parsed = uml_parse_vector_ifspec(params);
+ kfree(params);
"parsed" seems to contain pointers pointing to (parts of) the string
pointed to by "params", so it cannot be freed.
--
if (parsed == NULL) {Gr{oetje,eeting}s,
*error_out = "vector_config failed to parse parameters";
return -EINVAL;
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds