Re: [PATCH RFC net-next v2 06/12] net: mdio: mdio-bitbang: Separate C22 and C45 transactions

[Michael Walle]

Am 2023-01-03 14:15, schrieb Vladimir Oltean:
> On Wed, Dec 28, 2022 at 12:07:22AM +0100, Michael Walle wrote:
> > From: Andrew Lunn <andrew@xxxxxxx>
> >
> > The bitbbanging bus driver can perform both C22 and C45 transfers.
> > Create separate functions for each and register the C45 versions using
> > the new driver API calls.
> >
> > The SH Ethernet driver places wrappers around these functions. In
> > order to not break boards which might be using C45, add similar
> > wrappers for C45 operations.
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > Signed-off-by: Andrew Lunn <andrew@xxxxxxx>
> > Signed-off-by: Michael Walle <michael@xxxxxxxx>
> > ---
>
> Incomplete conversion, this breaks the build. Need to update all users
> of the bitbang driver (also davinci_mdio). Something like the diff 
> below
> fixes that, but it leaves the davinci_mdio driver in a partially
> converted state (if data->manual_mode is true, new API is used,
> otherwise old API is used). So another patch to convert the other case
> will likely be needed.

The intel build bot already notified me about this. Unfortunately, only
privately as I just noticed.

And yes, these are just the first 12 patches of a larger series.

-michael