Re: [PATCH] time: fix various kernel-doc problems

[Randy Dunlap]

Hi Ingo,

On 1/3/23 02:06, Ingo Molnar wrote:
> 
> * Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
> 
>> kernel/time/tick-oneshot.c:107: warning: expecting prototype for tick_check_oneshot_mode(). Prototype was for tick_oneshot_mode_active() instead
> 
>> --- a/kernel/time/tick-oneshot.c
>> +++ b/kernel/time/tick-oneshot.c
> 
>> @@ -103,7 +103,7 @@ int tick_switch_to_oneshot(void (*handle
>>   *
>>   * returns 1 when either nohz or highres are enabled. otherwise 0.
>>   */
>> -int tick_oneshot_mode_active(void)
>> +int tick_check_oneshot_mode(void)
>>  {
>>  	unsigned long flags;
>>  	int ret;
> 
> This one looks wrong - did you change the name on the wrong line?

Yes, sorry about that.

> I've applied your patch, but fixed the above hunk to be:
> 
> @@ -99,7 +99,7 @@ int tick_switch_to_oneshot(void (*handle
>  }
>  
>  /**
> - * tick_check_oneshot_mode - check whether the system is in oneshot mode
> + * tick_oneshot_mode_active - check whether the system is in oneshot mode
>   *
>   * returns 1 when either nohz or highres are enabled. otherwise 0.
>   */
> 
> Thanks,

Thank you also.

-- 
~Randy