Re: [PATCH v5 3/5] hisi_acc_vfio_pci: register debugfs for hisilicon migration driver

[liulongfang]

On 2023/1/3 23:07, Jason Gunthorpe Wrote:
> On Sat, Dec 17, 2022 at 02:32:46PM +0800, Longfang Liu wrote:
>> On the debugfs framework of VFIO, register the debug function
>> for the live migration driver of the hisilicon accelerator device.
>>
>> On the basis of the original public debug function, a private debug
>> function is added:
>>
>> mig_data file: used to get the migration data of the live migration device
>> mig_attr file: used to get device attributes of the live migration device
>> debug file: used to test for acquiring and writing device state data
>> for VF device.
>>
>> Signed-off-by: Longfang Liu <liulongfang@xxxxxxxxxx>
>> ---
>>  .../vfio/pci/hisilicon/hisi_acc_vfio_pci.c    | 276 ++++++++++++++++++
>>  .../vfio/pci/hisilicon/hisi_acc_vfio_pci.h    |  11 +
>>  2 files changed, 287 insertions(+)
> 
> You should put this all in its own file and not compile it when
> debugfs is turned off as well.
> 

Here use this macro #ifdef CONFIG_DEBUG_FS to wrap the creation part of debugfs.
Do you think it can be handled like this?

> Jason
> .
> 
Thanks,
Longfang.