Re: [PATCH v2 3/7] powerpc/secvar: Use sysfs_emit() instead of sprintf()
From: Andrew Donnellan
Date: Wed Jan 04 2023 - 02:12:49 EST
On Fri, 2022-12-30 at 15:20 +1100, Russell Currey wrote:
> The secvar format string and object size sysfs files are both ASCII
> text, and should use sysfs_emit(). No functional change.
>
> Suggested-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Russell Currey <ruscur@xxxxxxxxxx>
LGTM
Reviewed-by: Andrew Donnellan <ajd@xxxxxxxxxxxxx>
> ---
> v2: new
>
> arch/powerpc/kernel/secvar-sysfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/kernel/secvar-sysfs.c
> b/arch/powerpc/kernel/secvar-sysfs.c
> index 1ee4640a2641..02e9fee1552e 100644
> --- a/arch/powerpc/kernel/secvar-sysfs.c
> +++ b/arch/powerpc/kernel/secvar-sysfs.c
> @@ -35,7 +35,7 @@ static ssize_t format_show(struct kobject *kobj,
> struct kobj_attribute *attr,
> if (rc)
> goto out;
>
> - rc = sprintf(buf, "%s\n", format);
> + rc = sysfs_emit(buf, "%s\n", format);
>
> out:
> of_node_put(node);
> @@ -57,7 +57,7 @@ static ssize_t size_show(struct kobject *kobj,
> struct kobj_attribute *attr,
> return rc;
> }
>
> - return sprintf(buf, "%llu\n", dsize);
> + return sysfs_emit(buf, "%llu\n", dsize);
> }
>
> static ssize_t data_read(struct file *filep, struct kobject *kobj,
--
Andrew Donnellan OzLabs, ADL Canberra
ajd@xxxxxxxxxxxxx IBM Australia Limited