Re: [PATCH v1 1/1] media: i2c: st-vgxy61: Use asm intead of asm-generic

[Andy Shevchenko]

On Wed, Jan 04, 2023 at 10:27:14AM +0100, Benjamin Mugnier wrote:
> On 1/3/23 15:52, Andy Shevchenko wrote:

...

> > -#include <asm-generic/unaligned.h>
> >  #include <linux/clk.h>
> >  #include <linux/delay.h>
> >  #include <linux/gpio/consumer.h>
> > @@ -15,6 +14,9 @@
> >  #include <linux/pm_runtime.h>
> >  #include <linux/regulator/consumer.h>
> >  #include <linux/units.h>
> > +
> > +#include <asm/unaligned.h>

> Any particular reason not to keep the alphabetical sort ?

It's kept in an order in each of the groups of headers.

The main rule here is to go from most generic headers to the particular ones.
asm/* are definitely more particular than linux/* ones.

> >  #include <media/mipi-csi2.h>
> >  #include <media/v4l2-async.h>
> >  #include <media/v4l2-ctrls.h>

-- 
With Best Regards,
Andy Shevchenko