Re: [Patch v3 -mm 2/2] mm/kasan: simplify and refine kasan_cache code

From: Vlastimil Babka
Date: Wed Jan 04 2023 - 08:48:34 EST


On 1/4/23 07:06, Feng Tang wrote:
> struct 'kasan_cache' has a member 'is_kmalloc' indicating whether
> its host kmem_cache is a kmalloc cache. With newly introduced
> is_kmalloc_cache() helper, 'is_kmalloc' and its related function can
> be replaced and removed.
>
> Also 'kasan_cache' is only needed by KASAN generic mode, and not by
> SW/HW tag modes, so refine its protection macro accordingly, suggested
> by Andrey Konoval.
>
> Signed-off-by: Feng Tang <feng.tang@xxxxxxxxx>
> Reviewed-by: Andrey Konovalov <andreyknvl@xxxxxxxxx>

Acked-by: Vlastimil Babka <vbabka@xxxxxxx>

> ---
> Changlog:
>
> Since v2:
> * Rebase latest -mm tree, fix a conflict with kasan changes

As it doesn't apply to 6.2-rc2, I assume (as with v2) the mm tree will be a
better route for both patches than slab. Thanks.

> * Collect Reviewed-by tag
>
> Since v1
> * Use CONFIG_KASAN_GENERIC instead of CONFIG_KASAN for 'kasan_cache',
> as suggested by Andrey Konovalov
>