Re: [PATCH 2/3] bus: add Wiegand bus driver
From: Greg KH
Date: Wed Jan 04 2023 - 09:09:02 EST
On Wed, Jan 04, 2023 at 02:34:13PM +0100, Martin Zaťovič wrote:
> Add a bus driver for Wiegand protocol. The bus driver handles
> Wiegand controller and Wiegand device managemement and driver
> matching. The bus driver defines the structures for Wiegand
> controllers and Wiegand devices. Wiegand controller structure
> contains the format and payload_len fields to add support for
> different format messages. This should be handled by the
> controller driver.
>
> Each Wiegand controller should be associated with one Wiegand
> device, as Wiegand is typically a point-to-point bus.
>
> Signed-off-by: Martin Zaťovič <m.zatovic1@xxxxxxxxx>
> ---
> MAINTAINERS | 2 +
> drivers/bus/Kconfig | 5 +
> drivers/bus/Makefile | 1 +
> drivers/bus/wiegand.c | 768 ++++++++++++++++++++++++++++++++++++++++
Why is this here, yet the driver in drivers/wiegand/ ?
Why not put the bus logic in there as well?
thanks,
greg k-h