Re: [PATCH] perf: Add missing sys/types.h include

[Ian Rogers]

On Wed, Jan 4, 2023 at 10:23 AM Jesus Sanchez-Palencia
<jesussanp@xxxxxxxxxx> wrote:
>
> Not all libc implementations define ssize_t as part of stdio.h like
> glibc does since the standard only requires this type to be defined by
> unistd.h and sys/types.h. For this reason the perf build is currently
> broken for toolchains based on uClibc, for instance.
>
> Include sys/types.h explicitly to fix that. This is a follow up to
> commit 378ef0f5d9d7 ("perf build: Use libtraceevent from the system").
>
> Signed-off-by: Jesus Sanchez-Palencia <jesussanp@xxxxxxxxxx>

Acked-by: Ian Rogers <irogers@xxxxxxxxxx>

Thanks,
Ian

> ---
>  tools/perf/util/trace-event.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/util/trace-event.h b/tools/perf/util/trace-event.h
> index add6c5d9531c..9b3cd79cca12 100644
> --- a/tools/perf/util/trace-event.h
> +++ b/tools/perf/util/trace-event.h
> @@ -4,6 +4,7 @@
>
>  #include <stdbool.h>
>  #include <stdio.h>
> +#include <sys/types.h>
>  #include <linux/types.h>
>
>  struct evlist;
> --
> 2.39.0.314.g84b9a713c41-goog
>