Re: [PATCH v4] leds: simatic-ipc-leds-gpio: make sure we have the GPIO providing driver

From: Henning Schild
Date: Wed Jan 04 2023 - 14:30:44 EST


Am Wed, 4 Jan 2023 17:51:33 +0200
schrieb Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>:

> On Wed, Jan 04, 2023 at 03:39:24PM +0100, Henning Schild wrote:
> > Am Wed, 4 Jan 2023 14:24:30 +0000
> > schrieb Lee Jones <lee@xxxxxxxxxx>:
>
> ...
>
> > As we speak i already have the third box to eventually support,
> > which will likely be similar but this time around with
> > PINCTRL_ELKHARTLAKE
>
> A bit of offtopic here.
>
> Are you able to get / fix / ... the firmware to work with the
> upstreamed version of pin control driver for Intel Elkhart Lake?
>
> (I'm asking this in terms of the
> https://bugzilla.kernel.org/show_bug.cgi?id=213365)
>

I can not tell. At the moment i am in a Siemens internal review where i
see code that is not even close to being ready for upstream. Somewhat
open-coded again from what it looks like.

And i do not have the machine the code is for.

Let me say "it is complicated" but some point in time a device with
LEDs attached to PINCTRL_ELKHARTLAKE will be proposed. Likely by me,
when i hopefully have such a device on my desk.

Henning