Re: [PATCH v2 1/1] mm: fix vma->anon_name memory leak for anonymous shmem VMAs

From: David Hildenbrand
Date: Thu Jan 05 2023 - 04:06:30 EST


On 05.01.23 01:02, Suren Baghdasaryan wrote:
free_anon_vma_name() is missing a check for anonymous shmem VMA which
leads to a memory leak due to refcount not being dropped. Fix this by
calling anon_vma_name_put() unconditionally. It will free vma->anon_name
whenever it's non-NULL.

Fixes: d09e8ca6cb93 ("mm: anonymous shared memory naming")
Signed-off-by: Suren Baghdasaryan <surenb@xxxxxxxxxx>
Suggested-by: David Hildenbrand <david@xxxxxxxxxx>
Reported-by: syzbot+91edf9178386a07d06a7@xxxxxxxxxxxxxxxxxxxxxxxxx
Cc: David Hildenbrand <david@xxxxxxxxxx>
Cc: Hugh Dickins <hughd@xxxxxxxxxx>
Cc: Pasha Tatashin <pasha.tatashin@xxxxxxxxxx>


Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

--
Thanks,

David / dhildenb