Re: [PATCH] s390/qeth: convert sysfs snprintf to sysfs_emit
From: Simon Horman
Date: Thu Jan 05 2023 - 07:02:16 EST
On Wed, Dec 28, 2022 at 12:20:15PM +0000, patchwork-bot+netdevbpf@xxxxxxxxxx wrote:
> Hello:
>
> This patch was applied to netdev/net.git (master)
> by David S. Miller <davem@xxxxxxxxxxxxx>:
>
> On Tue, 27 Dec 2022 19:03:52 +0800 you wrote:
> > From: Xuezhi Zhang <zhangxuezhi1@xxxxxxxxxxx>
> >
> > Follow the advice of the Documentation/filesystems/sysfs.rst
> > and show() should only use sysfs_emit() or sysfs_emit_at()
> > when formatting the value to be returned to user space.
> >
> > Signed-off-by: Xuezhi Zhang <zhangxuezhi1@xxxxxxxxxxx>
> >
> > [...]
>
> Here is the summary with links:
> - s390/qeth: convert sysfs snprintf to sysfs_emit
> https://git.kernel.org/netdev/net/c/c2052189f19b
I'm a little late to the party here, but should the use of sprintf() in
show functions elsewhere in the qeth_core_sys.c also be updated?