[syzbot] [udf?] KASAN: null-ptr-deref Write in udf_fiiter_add_entry

From: syzbot
Date: Thu Jan 05 2023 - 11:43:39 EST


Hello,

syzbot found the following issue on:

HEAD commit: c76083fac3ba Add linux-next specific files for 20221226
git tree: linux-next
console+strace: https://syzkaller.appspot.com/x/log.txt?x=104afeb2480000
kernel config: https://syzkaller.appspot.com/x/.config?x=c217c755f1884ab6
dashboard link: https://syzkaller.appspot.com/bug?extid=b1b66db80fe98b733c58
compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=136ca714480000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=16fcd5da480000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/e388f26357fd/disk-c76083fa.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/e24f0bae36d5/vmlinux-c76083fa.xz
kernel image: https://storage.googleapis.com/syzbot-assets/a5a69a059716/bzImage-c76083fa.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/bb457662f7c3/mount_0.gz

The issue was bisected to:

commit 869e9be21b1c67010d215c83c38b32f6cbd080cc
Author: Jan Kara <jack@xxxxxxx>
Date: Tue Dec 20 11:38:45 2022 +0000

udf: Allocate name buffer in directory iterator on heap

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=15ce5eb2480000
final oops: https://syzkaller.appspot.com/x/report.txt?x=17ce5eb2480000
console output: https://syzkaller.appspot.com/x/log.txt?x=13ce5eb2480000

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+b1b66db80fe98b733c58@xxxxxxxxxxxxxxxxxxxxxxxxx
Fixes: 869e9be21b1c ("udf: Allocate name buffer in directory iterator on heap")

RAX: ffffffffffffffda RBX: 0000000000000002 RCX: 00007fcd6a74ea39
RDX: 0000000000000000 RSI: 0000000000141043 RDI: 00000000200000c0
RBP: 00007ffc262fb620 R08: 0000000000000002 R09: 00007ffc262fb630
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000004
R13: 00007ffc262fb660 R14: 00007ffc262fb640 R15: 0000000000000008
</TASK>
==================================================================
BUG: KASAN: null-ptr-deref in udf_fiiter_add_entry+0x75b/0x10d0 fs/udf/namei.c:316
Write of size 4 at addr 0000000000000000 by task syz-executor153/5085

CPU: 0 PID: 5085 Comm: syz-executor153 Not tainted 6.2.0-rc1-next-20221226-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0xd1/0x138 lib/dump_stack.c:106
kasan_report+0xc0/0xf0 mm/kasan/report.c:517
check_region_inline mm/kasan/generic.c:183 [inline]
kasan_check_range+0x141/0x190 mm/kasan/generic.c:189
memcpy+0x3d/0x60 mm/kasan/shadow.c:66
udf_fiiter_add_entry+0x75b/0x10d0 fs/udf/namei.c:316
udf_add_nondir+0xda/0x360 fs/udf/namei.c:349
udf_create+0x12c/0x180 fs/udf/namei.c:384
lookup_open.isra.0+0xee7/0x1270 fs/namei.c:3413
open_last_lookups fs/namei.c:3481 [inline]
path_openat+0x975/0x2a50 fs/namei.c:3711
do_filp_open+0x1ba/0x410 fs/namei.c:3741
do_sys_openat2+0x16d/0x4c0 fs/open.c:1310
do_sys_open fs/open.c:1326 [inline]
__do_sys_open fs/open.c:1334 [inline]
__se_sys_open fs/open.c:1330 [inline]
__x64_sys_open+0x11d/0x1c0 fs/open.c:1330
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7fcd6a74ea39
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 11 15 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffc262fb5f8 EFLAGS: 00000246 ORIG_RAX: 0000000000000002
RAX: ffffffffffffffda RBX: 0000000000000002 RCX: 00007fcd6a74ea39
RDX: 0000000000000000 RSI: 0000000000141043 RDI: 00000000200000c0
RBP: 00007ffc262fb620 R08: 0000000000000002 R09: 00007ffc262fb630
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000004
R13: 00007ffc262fb660 R14: 00007ffc262fb640 R15: 0000000000000008
</TASK>
==================================================================


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@xxxxxxxxxxxxxxxx.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
For information about bisection process see: https://goo.gl/tpsmEJ#bisection
syzbot can test patches for this issue, for details see:
https://goo.gl/tpsmEJ#testing-patches