Re: [PATCH 0/4] ARM: dts: sunxi: Add MangoPi MQ-R board support

[Andre Przywara]

On Fri,  6 Jan 2023 01:01:51 +0000
Andre Przywara <andre.przywara@xxxxxxx> wrote:

> The MangoPi MQ-R is a small SBC with the Allwinner T113-s3 SoC. That is
> a very close relative to the Allwinner D1/D1s SoCs, but with Arm
> Cortex-A7 cores, and 128 MB of SIP co-packaged DDR3 DRAM.
> 
> This series introduces the missing T113-s .dtsi, which builds on top of
> the D1/D1s .dtsi, but adds the ARM specific peripherals, like the CPU
> cores, the arch timer, the GIC and the PMU.
> This requires to add a symlink to the RISC-V DT directory in patch 1/4,
> to be able to easily reference the base .dtsi from other architecture
> directories.

First, forgot to mention that this builds on top of Samuel's D1/D1s DT
series:
https://lore.kernel.org/linux-arm-kernel/20221231233851.24923-1-samuel@xxxxxxxxxxxx/
To actually boot, this also relies on the R528/T113s clock series:
https://lore.kernel.org/linux-arm-kernel/20221231231429.18357-1-samuel@xxxxxxxxxxxx/

> After I had written most of the board .dts, I realised that the
> MangoPi MQ is almost the same, minus the RISC-V/ARM difference. I am a
> bit unsure if we should share more of the board .dts, though, as this
> would go cross architectures. I am open to any comments here.

So after getting some sleep and having a look at the MangoPi website
again, I realised that there is of course a D1s edition of the MQ-R as
well. So shall we split this up like this:
- a sunxi-mangopi-mq.dtsi, which contains all the board specific nodes
- a sun20i-d1-mangopi-mq.dts, which includes that and sun20i-d1s.dtsi
- a sun20i-d1-mangopi-mq-r.dts, which maybe includes
  sun20i-d1-mangopi-mq.dts, and just overwrites the model name?
- a sun8i-t113s-mangopi-mq-r.dts, which includes sunxi-mangopi-mq.dtsi
  and sun8i-t113s.dtsi

Let me know if this useful or more confusing.

Cheers,
Andre


> Andre Przywara (4):
>   dts: add riscv include prefix link
>   ARM: dts: sunxi: add Allwinner T113-s SoC .dtsi
>   dt-bindings: arm: sunxi: document MangoPi MQ-R board name
>   ARM: dts: sunxi: add MangoPi MQ-R board
> 
>  .../devicetree/bindings/arm/sunxi.yaml        |   5 +
>  arch/arm/boot/dts/Makefile                    |   1 +
>  .../arm/boot/dts/sun8i-t113s-mangopi-mq-r.dts | 160 ++++++++++++++++++
>  arch/arm/boot/dts/sun8i-t113s.dtsi            |  59 +++++++
>  scripts/dtc/include-prefixes/riscv            |   1 +
>  5 files changed, 226 insertions(+)
>  create mode 100644 arch/arm/boot/dts/sun8i-t113s-mangopi-mq-r.dts
>  create mode 100644 arch/arm/boot/dts/sun8i-t113s.dtsi
>  create mode 120000 scripts/dtc/include-prefixes/riscv
>