Re: [PATCH v3 0/2] riscv,isa fixups
From: Conor Dooley
Date: Fri Jan 06 2023 - 13:34:45 EST
On Fri, Jan 06, 2023 at 10:27:48AM -0800, Palmer Dabbelt wrote:
> On Mon, 05 Dec 2022 09:44:58 PST (-0800), Conor Dooley wrote:
> > From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> >
> > I noticed ~today~ while looking at the isa manual that I had not
> > accounted for another couple of edge cases with my regex. As before, I
> > think attempting to validate the canonical order for multiletter stuff
> > makes no sense - but we should totally try to avoid false-positives for
> > combinations that are known to be valid.
> >
> > All I've changed for v2 was collecting tags & adding in the missing
> > commit reference that Heiko pointed out.
> >
> > v3 fixes an issue Jess spotted - it's *any* multi-letter extension that
> > can come immediately after the single-letter ones, not just ones
> > starting with Z.
> >
> > @Palmer, either you can take this once the DT folks have ACKed it if you
> > like, or I will take onto some v6.2-rcN fixes branch. I don't think that
> > there is any urgency :)
>
> Sorry I missed these.
>
> Reviewed-by: Palmer Dabbelt <palmer@xxxxxxxxxxxx>
> Acked-by: Palmer Dabbelt <palmer@xxxxxxxxxxxx>
>
> We can just do a shared tag if you have stuff that depends on them? That'll
> let me keep fixes clean, as I'm running the DT stuff too now. Though maybe
> it doesn't matter so much because I'm not really taking any DT stuff.
Nah, shared tag is not needed.
Noone's got a DT with multiletter stuff that needs to be merged yet.
Feel free to take on on fixes or for-next.
Thanks,
Conor.
Attachment:
signature.asc
Description: PGP signature