Re: [PATCH v2 1/2] Revert "ARM: dts: armada-38x: Fix compatible string for gpios"

[Andrew Lunn]

On Sat, Jan 07, 2023 at 03:41:48PM +0100, Klaus Kudielka wrote:
> This reverts commit c4de4667f15d04ef5920bacf41e514ec7d1ef03d, which causes
> a regression on Turris Omnia (Armada 385): GPIO interrupts cease to work,
> ending up in the DSA switch being non-functional.
> 
> The blamed commit is incorrect in the first place:
> If compatible = "marvell,armadaxp-gpio", the second (address, size) pair
> of the reg property must to point to the per-CPU interrupt registers
> <0x18800 0x30> / <0x18840 0x30>, and not to the blink enable registers
> <0x181c0 0x08> / <0x181c8 0x08>.
> 
> But even fixing that leaves the GPIO interrupts broken on the Omnia.
> 
> Furthermore:
> Commit 5f79c651e81e explains very well, why the gpio-mvebu driver does not
> work reliably with per-CPU interrupts.
> Commit 988c8c0cd04d deprecates compatible = marvell,armadaxp-gpio for this
> reason.
> 
> Fixes: c4de4667f15d ("ARM: dts: armada-38x: Fix compatible string for gpios")
> Reported-by: Klaus Kudielka <klaus.kudielka@xxxxxxxxx>
> Link: https://lore.kernel.org/r/f24474e70c1a4e9692bd596ef6d97ceda9511245.camel@xxxxxxxxx/
> 
> Signed-off-by: Klaus Kudielka <klaus.kudielka@xxxxxxxxx>

Hi Klaus

I was hoping Pali would comment, maybe fix it. But i think enough time
has passed, we should accept your reverts.

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew