Re: [PATCH] dt-bindings: phy: qcom,qusb2: do not define properties in "if" block

From: Rob Herring
Date: Sun Jan 08 2023 - 13:05:46 EST



On Sat, 24 Dec 2022 16:42:26 +0100, Krzysztof Kozlowski wrote:
> It is more readable to define properties in top-level "properties:" and
> restrict them (if needed) per compatible in the "if" block. Defining
> properties in "if" block does not work correctly with
> additionalProperties:false:
>
> sc7180-trogdor-pazquel-lte-ti.dtb: phy@88e3000: 'qcom,bias-ctrl-value', 'qcom,charge-ctrl-value', 'qcom,hsdisc-trim-value',
> 'qcom,imp-res-offset-value', 'qcom,preemphasis-level', 'qcom,preemphasis-width' do not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
> .../bindings/phy/qcom,qusb2-phy.yaml | 160 ++++++++++--------
> 1 file changed, 85 insertions(+), 75 deletions(-)
>

Acked-by: Rob Herring <robh@xxxxxxxxxx>