Re: [PATCH 03/12] dt-bindings: nvmem: convert amlogic-meson-mx-efuse.txt to dt-schema

[Neil Armstrong]

On 26/11/2022 00:04, Martin Blumenstingl wrote:
> Hi Neil,
>
> thanks for your work on this!
>
> On Fri, Nov 18, 2022 at 3:33 PM Neil Armstrong
> <neil.armstrong@xxxxxxxxxx> wrote:
> [...]
> > +        #address-cells = <1>;
> > +        #size-cells = <1>;
> > +
> > +        sn: sn@14 {
> > +            reg = <0x14 0x10>;
> > +        };
> > +
> > +        eth_mac: mac@34 {
> > +            reg = <0x34 0x10>;
> > +        };
> > +
> > +        bid: bid@46 {
> > +            reg = <0x46 0x30>;
> > +        };
> I assume you took these examples from the newer, GX eFuse?
> Unfortunately on boards with these older SoCs the serial number and
> MAC address are often not stored in the eFuse.
> This is just an example, so I won't be sad if we keep them. To avoid
> confusion I suggest switching to different examples:
>    ethernet_mac_address: mac@1b4 {
>      reg = <0x1b4 0x6>;
>    };
>    temperature_calib: calib@1f4 {
>       reg = <0x1f4 0x4>;
>    };
>
> What do you think?


Sure switched to it !

Neil
> Best regards,
> Martin