Re: [PATCH] soc: qcom: ramp_controller: Make things static

[AngeloGioacchino Del Regno]

Il 10/01/23 05:20, Bjorn Andersson ha scritto:
> The five msm8976_cfg_* objects ought to be static, as reported by LKP
> and sparse, fix this.
>
> drivers/soc/qcom/ramp_controller.c:235:27: sparse: sparse: symbol 'msm8976_cfg_dfs_sid' was not declared. Should it be static?
> drivers/soc/qcom/ramp_controller.c:246:27: sparse: sparse: symbol 'msm8976_cfg_link_sid' was not declared. Should it be static?
> drivers/soc/qcom/ramp_controller.c:250:27: sparse: sparse: symbol 'msm8976_cfg_lmh_sid' was not declared. Should it be static?
> drivers/soc/qcom/ramp_controller.c:256:27: sparse: sparse: symbol 'msm8976_cfg_ramp_en' was not declared. Should it be static?
> drivers/soc/qcom/ramp_controller.c:262:27: sparse: sparse: symbol 'msm8976_cfg_ramp_dis' was not declared. Should it be static?
>
> Fixes: a723c95fa137 ("soc: qcom: Add Qualcomm Ramp Controller driver")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Bjorn Andersson <quic_bjorande@xxxxxxxxxxx>

Thanks for catching that and swiftly fixing it!

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>

Cheers,
Angelo