Re: [PATCH 4/9] drm/vc4: hdmi: Rename full range helper

[Thomas Zimmermann]

Am 07.12.22 um 17:07 schrieb Maxime Ripard:
> From: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>
>
> The VC4 HDMI driver has a helper function to figure out whether full
> range or limited range RGB is being used called
> vc4_hdmi_is_full_range_rgb().
>
> We'll need it to support other colorspaces, so let's rename it to
> vc4_hdmi_is_full_range().
>
> Signed-off-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>
> Signed-off-by: Maxime Ripard <maxime@xxxxxxxxxx>

Reviewed-by: Thomas Zimmermann <tzimmermann@xxxxxxx>

> ---
>   drivers/gpu/drm/vc4/vc4_hdmi.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
> index 488a4012d422..51469939a8b4 100644
> --- a/drivers/gpu/drm/vc4/vc4_hdmi.c
> +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
> @@ -149,8 +149,8 @@ static bool vc4_hdmi_mode_needs_scrambling(const struct drm_display_mode *mode,
>   	return clock > HDMI_14_MAX_TMDS_CLK;
>   }
>   
> -static bool vc4_hdmi_is_full_range_rgb(struct vc4_hdmi *vc4_hdmi,
> -				       const struct drm_display_mode *mode)
> +static bool vc4_hdmi_is_full_range(struct vc4_hdmi *vc4_hdmi,
> +				   const struct drm_display_mode *mode)
>   {
>   	struct drm_display_info *display = &vc4_hdmi->connector.display_info;
>   
> @@ -892,7 +892,7 @@ static void vc4_hdmi_set_avi_infoframe(struct drm_encoder *encoder)
>   
>   	drm_hdmi_avi_infoframe_quant_range(&frame.avi,
>   					   connector, mode,
> -					   vc4_hdmi_is_full_range_rgb(vc4_hdmi, mode) ?
> +					   vc4_hdmi_is_full_range(vc4_hdmi, mode) ?
>   					   HDMI_QUANTIZATION_RANGE_FULL :
>   					   HDMI_QUANTIZATION_RANGE_LIMITED);
>   	drm_hdmi_avi_infoframe_colorimetry(&frame.avi, cstate);
> @@ -1145,7 +1145,7 @@ static void vc4_hdmi_csc_setup(struct vc4_hdmi *vc4_hdmi,
>   	csc_ctl = VC4_SET_FIELD(VC4_HD_CSC_CTL_ORDER_BGR,
>   				VC4_HD_CSC_CTL_ORDER);
>   
> -	if (!vc4_hdmi_is_full_range_rgb(vc4_hdmi, mode)) {
> +	if (!vc4_hdmi_is_full_range(vc4_hdmi, mode)) {
>   		/* CEA VICs other than #1 requre limited range RGB
>   		 * output unless overridden by an AVI infoframe.
>   		 * Apply a colorspace conversion to squash 0-255 down
> @@ -1298,7 +1298,7 @@ static void vc5_hdmi_csc_setup(struct vc4_hdmi *vc4_hdmi,
>   	case VC4_HDMI_OUTPUT_RGB:
>   		if_xbar = 0x354021;
>   
> -		if (!vc4_hdmi_is_full_range_rgb(vc4_hdmi, mode))
> +		if (!vc4_hdmi_is_full_range(vc4_hdmi, mode))
>   			vc5_hdmi_set_csc_coeffs(vc4_hdmi, vc5_hdmi_csc_full_rgb_to_limited_rgb);
>   		else
>   			vc5_hdmi_set_csc_coeffs(vc4_hdmi, vc5_hdmi_csc_full_rgb_unity);

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

Attachment: OpenPGP_signature
Description: OpenPGP digital signature