Re: [PATCH v5 4/9] iov_iter: Add a function to extract a page list from an iterator

From: Christoph Hellwig
Date: Thu Jan 12 2023 - 02:56:11 EST

Next message: Shakeel Butt: "Re: [PATCH 0/4] Track exported dma-buffers with memcg"
Previous message: Thomas Zimmermann: "Re: [PATCH 11/11] video/aperture: Only remove sysfb on the default vga pci device"
In reply to: David Howells: "[PATCH v5 4/9] iov_iter: Add a function to extract a page list from an iterator"
Next in thread: Al Viro: "Re: [PATCH v5 4/9] iov_iter: Add a function to extract a page list from an iterator"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

> + BUG(); // if it had been empty, we wouldn't get called

Please use a normal /* */ comment here.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Next message: Shakeel Butt: "Re: [PATCH 0/4] Track exported dma-buffers with memcg"
Previous message: Thomas Zimmermann: "Re: [PATCH 11/11] video/aperture: Only remove sysfb on the default vga pci device"
In reply to: David Howells: "[PATCH v5 4/9] iov_iter: Add a function to extract a page list from an iterator"
Next in thread: Al Viro: "Re: [PATCH v5 4/9] iov_iter: Add a function to extract a page list from an iterator"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]