Re: [PATCH net-next 03/10] net: mdio: mux-bcm-iproc: Separate C22 and C45 transactions

From: Florian Fainelli
Date: Thu Jan 12 2023 - 16:32:11 EST


On 1/12/23 07:15, Michael Walle wrote:
From: Andrew Lunn <andrew@xxxxxxx>

The MDIO mux broadcom iproc can perform both C22 and C45 transfers.
Create separate functions for each and register the C45 versions using
the new API calls.

Signed-off-by: Andrew Lunn <andrew@xxxxxxx>
Signed-off-by: Michael Walle <michael@xxxxxxxx>
---
Apparently, in the c45 case, the reg value including the MII_ADDR_C45
bit is written to the hardware. Looks weird, that a "random" software
bit is written to a register. Florian is that correct? Also, with this
patch this flag isn't set anymore.

We should be masking the MII_ADDR_C45 bit because the MDIO_ADDR_OFFSET only defines bits 0 through 20 as being read/write and bits above being read-only. In practice, this is probably not making any difference or harm.
--
Florian