Re: [PATCH 3/4] tracing: Add trace_array_puts() to write into instance

[Steven Rostedt]

On Thu, 12 Jan 2023 16:26:27 -0700
Ross Zwisler <zwisler@xxxxxxxxxx> wrote:

> > +/**
> > + * trace_array_puts - write a constant string into the trace buffer.
> > + * @tr:    The trace array to write to
> > + * @ip:	   The address of the caller  
> 
> @ip is not an arg to trace_array_puts(), an can be dropped from the comment.

Good catch.

My first version had it, and then I realized I didn't like it (to be in
sync with the internal version of __trace_puts()". But I forgot to update
the kernel doc. Thanks for pointing that out.

> 
> Other than that, you can add:
> 
> Reviewed-by: Ross Zwisler <zwisler@xxxxxxxxxx>

Thanks,

-- Steve