Re: [PATCH] drm/panel: boe-tv101wum-nl6: Ensure DSI writes succeed during disable
From: Sam Ravnborg
Date: Fri Jan 13 2023 - 10:02:20 EST
Hi Stephen,
On Tue, Jan 10, 2023 at 11:29:41AM -0800, Stephen Boyd wrote:
> Quoting Sam Ravnborg (2023-01-07 12:28:41)
>
> >
> > For this case we could ask ourself if the display needs to enter sleep
> > mode right before we disable the regulator. But if the regulator is
> > fixed, so the disable has no effect, this seems OK.
>
> What do you mean by fixed?
What I tried to say here is if we have a fixed regulator - or in others
words a supply voltage we cannot turn off, then entering sleep mode is
important to reduce power consumption.
But any sane design where power consumption is a concern will have the
possibility to turn off the power anyway.
>
> >
> > Please fix the unprepare to not jump out early, on top of or together
> > with the other fix.
>
> After this patch the unprepare only bails out early if the bool
> 'prepared' flag isn't set.
OK, then everything is fine.
Sam