Re: [PATCH v2 2/2] dt-bindings: rtc: Move rv3028 from trivial-rtc.yaml into own schema file

From: Rob Herring
Date: Fri Jan 13 2023 - 14:25:15 EST


On Wed, Jan 11, 2023 at 05:34:04PM +0100, Wadim Egorov wrote:
> Move RV3028 RTC bindings from trivial-rtc.yaml into microcrystal,rv3032.yaml.

That's obvious from the diff. What's not obvious is 'why' and the commit
message should answer that. I assume something about it makes it not
trivial.

>
> Signed-off-by: Wadim Egorov <w.egorov@xxxxxxxxx>
> ---
> v2:
> - Update subject
> - Remove not needed quotes
> - Remove start-year
> - Use unevaluatedProperties instead of additionalProperties
> ---
> .../bindings/rtc/microcrystal,rv3028.yaml | 54 +++++++++++++++++++
> .../devicetree/bindings/rtc/trivial-rtc.yaml | 2 -
> 2 files changed, 54 insertions(+), 2 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml

Otherwise,

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>