Re: [PATCH] ARM: dts: Fix User button on stm32mp135f-dk

[Amelie Delaunay]

On 1/11/23 11:38, Krzysztof Kozlowski wrote:
> On 11/01/2023 11:07, Amelie Delaunay wrote:
> > This patch fixes the following dtbs_check warning on stm32mp135f-dk:
> > arch/arm/boot/dts/stm32mp135f-dk.dtb: gpio-keys: 'user-pa13' does not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', 'pinctrl-[0-9]+'
> >  From schema: Documentation/devicetree/bindings/input/gpio-keys.yaml
> >
> > It renames user-pa13 node into button-user so that it matches gpio-keys
> > bindings.
> >
> > Fixes: 57012d79fefd ("ARM: dts: stm32: add UserPA13 button on stm32mp135f-dk")
>
> No blank lines between the tags, but I would drop the Fixes anyway. This
> is not a bug, but convention and coding style.

Blank line + Fixes tag dropped in v2. Thanks

> > Signed-off-by: Amelie Delaunay <amelie.delaunay@xxxxxxxxxxx>
> > ---
> >   arch/arm/boot/dts/stm32mp135f-dk.dts | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/stm32mp135f-dk.dts b/arch/arm/boot/dts/stm32mp135f-dk.dts
> > index 9ff5a3eaf55b..931877d6ddb9 100644
> > --- a/arch/arm/boot/dts/stm32mp135f-dk.dts
> > +++ b/arch/arm/boot/dts/stm32mp135f-dk.dts
> > @@ -40,7 +40,7 @@ optee@dd000000 {
> >   	gpio-keys {
> >   		compatible = "gpio-keys";
> >   
> > -		user-pa13 {
> > +		button-user {
>
> Best regards,
> Krzysztof

Regards,
Amelie