Re: [PATCH net-next] brcm80211: use strscpy() to instead of strncpy()

[Kalle Valo]

Leon Romanovsky <leon@xxxxxxxxxx> writes:

> On Mon, Jan 16, 2023 at 01:08:36PM +0000, Kalle Valo wrote:
>> <yang.yang29@xxxxxxxxxx> wrote:
>> 
>> > From: Xu Panda <xu.panda@xxxxxxxxxx>
>> > 
>> > The implementation of strscpy() is more robust and safer.
>> > That's now the recommended way to copy NUL-terminated strings.
>> > 
>> > Signed-off-by: Xu Panda <xu.panda@xxxxxxxxxx>
>> > Signed-off-by: Yang Yang <yang.yang29@xxxxxxx>
>> 
>> Mismatch email in From and Signed-off-by lines:
>> 
>> From: <yang.yang29@xxxxxxxxxx>
>> Signed-off-by: Yang Yang <yang.yang29@xxxxxxx>
>> 
>> Patch set to Changes Requested.
>
> Kalle, please be aware of this response
> https://lore.kernel.org/netdev/20230113112817.623f58fa@xxxxxxxxxx/
>
> "I don't trust that you know what you're doing. So please don't send
> any more strncpy() -> strscpy() conversions for networking."

Good to know, thanks.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches