Re: [PATCH v2] documentation: fix Generic Block Device Capability

From: Fabio Fantoni
Date: Mon Jan 16 2023 - 13:29:21 EST


Il 16/01/2023 18:53, Christoph Hellwig ha scritto:
On Tue, Jan 10, 2023 at 02:21:04PM +0100, Fabio Fantoni wrote:
- * ``GENHD_FL_REMOVABLE``: indicates that the block device gives access to
+ * ``GENHD_FL_REMOVABLE`` (0x01): indicates that the block device gives access to
The numberic values really do not belong into the documentation. They
are just implementation details.

Thanks for reply, if values are not into the documentation see from /sys/block/<disk>/capability output what flags are enabled will require look to source code of include/linux/blkdev.h and Documentation/block/capability.rst will be less useful, or I'm wrong?