Re: [PATCH 2/6] arm64: dts: qcom: sdm845: move WCD9340 codec to separate file

[Krzysztof Kozlowski]

On 17/01/2023 04:56, Bjorn Andersson wrote:
> On Fri, Jan 13, 2023 at 05:22:41PM +0100, Krzysztof Kozlowski wrote:
>> WCD9340 codec node is not a property of the SoC, but board.  Move it to
>> separate file and include it in the specific boards.  On all others,
>> keep the Slimbus node disabled as it is empty.
>>
> 
> I think this seems like a reasonable idea. But without clearly
> documenting your intentions/guidelines we will soon have
> sdm845-display.dtsi, sdm845-pcie.dtsi etc.
> 
> So please start there.

You said like this started the process but it is already there for
sc7280. Where do you want to store such documentation? In commit msg?

> 
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>> ---
>>  .../boot/dts/qcom/sdm845-audio-wcd9340.dtsi   | 69 +++++++++++++++++++
>>  arch/arm64/boot/dts/qcom/sdm845-db845c.dts    |  1 +
>>  .../qcom/sdm845-xiaomi-beryllium-common.dtsi  |  1 +
>>  .../boot/dts/qcom/sdm845-xiaomi-polaris.dts   |  1 +
>>  arch/arm64/boot/dts/qcom/sdm845.dtsi          | 60 +---------------
>>  .../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts |  1 +
>>  .../boot/dts/qcom/sdm850-samsung-w737.dts     |  1 +
>>  7 files changed, 75 insertions(+), 59 deletions(-)
>>  create mode 100644 arch/arm64/boot/dts/qcom/sdm845-audio-wcd9340.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-audio-wcd9340.dtsi b/arch/arm64/boot/dts/qcom/sdm845-audio-wcd9340.dtsi
>> new file mode 100644
>> index 000000000000..5bcce7d0d709
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-audio-wcd9340.dtsi
> 
> Why does this include the substring "audio"?

To indicate it covers entire audio, which points me to the fact that
probably I can also move there sound node.

Best regards,
Krzysztof