Re: [PATCH v6 03/34] iov_iter: Pass I/O direction into iov_iter_get_pages*()

From: Christoph Hellwig
Date: Tue Jan 17 2023 - 03:47:13 EST


On Tue, Jan 17, 2023 at 08:44:16AM +0000, David Howells wrote:
> Also, I don't want it to be FOLL_WRITE or 0. I want it to be written
> explicitly in both cases. If you're going to insist on using FOLL_WRITE, then
> there should be a FOLL_READ to go with it, even if it's #defined to 0.

Well, that's not how FOLL_* works. And another new flag that is defined
to 0 but only used by some I/O callers is really confusing.