RE: [PATCH v4 2/2] media: dt-bindings: media: renesas,fcp: Document RZ/{G2L,V2L} FCPVD bindings

[Biju Das]

Hi all,

Gentle ping.

This patch is reviewed by Rob.

It is blocking for accepting SoC dtsi patches[1] through renesas-soc tree 

1] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20221122193415.1873179-2-biju.das.jz@xxxxxxxxxxxxxx/

Cheers,
Biju

> -----Original Message-----
> From: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> Sent: 22 November 2022 19:34
> To: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>; Rob Herring
> <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@xxxxxxxxxx>
> Cc: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>; Laurent Pinchart
> <laurent.pinchart@xxxxxxxxxxxxxxxx>; linux-media@xxxxxxxxxxxxxxx; linux-
> renesas-soc@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; Geert Uytterhoeven
> <geert+renesas@xxxxxxxxx>; Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx>;
> Rob Herring <robh@xxxxxxxxxx>
> Subject: [PATCH v4 2/2] media: dt-bindings: media: renesas,fcp: Document
> RZ/{G2L,V2L} FCPVD bindings
> 
> Document FCPVD found in RZ/G2L alike SoCs. FCPVD block is similar to FCP for
> VSP found on R-Car SoC's . It has 3 clocks compared to 1 clock on fcpv.
> Introduce new compatibles renesas,r9a07g044-fcpvd for RZ/G2{L,LC} and
> renesas,r9a07g054-fcpvd for RZ/V2L to handle this difference.
> 
> The 3 clocks are shared between du, vspd and fcpvd. No driver changes are
> required as generic compatible string "renesas,fcpv" will be used as a
> fallback.
> 
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> ---
> v3->v4:
>  * Added Rb tag from Rob.
> v2->v3:
>  * Updated the compatibles by replacing items->enum as
>    it is just one item.
> v1->v2:
>  * Documented RZ/{G2,V2}L FCPVD bindings
>  * Introduces new compatibles renesas,r9a07g0{44,54}-fcpvd
>  * Added clock-names property
>  * described clocks.
> ---
>  .../bindings/media/renesas,fcp.yaml           | 45 ++++++++++++++++---
>  1 file changed, 40 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> index 43f2fed8cd33..c6abe719881b 100644
> --- a/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> @@ -21,15 +21,22 @@ description: |
> 
>  properties:
>    compatible:
> -    enum:
> -      - renesas,fcpv # FCP for VSP
> -      - renesas,fcpf # FCP for FDP
> +    oneOf:
> +      - enum:
> +          - renesas,fcpv # FCP for VSP
> +          - renesas,fcpf # FCP for FDP
> +      - items:
> +          - enum:
> +              - renesas,r9a07g044-fcpvd # RZ/G2{L,LC}
> +              - renesas,r9a07g054-fcpvd # RZ/V2L
> +          - const: renesas,fcpv         # Generic FCP for VSP fallback
> 
>    reg:
>      maxItems: 1
> 
> -  clocks:
> -    maxItems: 1
> +  clocks: true
> +
> +  clock-names: true
> 
>    iommus:
>      maxItems: 1
> @@ -49,6 +56,34 @@ required:
> 
>  additionalProperties: false
> 
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - renesas,r9a07g044-fcpvd
> +              - renesas,r9a07g054-fcpvd
> +    then:
> +      properties:
> +        clocks:
> +          items:
> +            - description: Main clock
> +            - description: Register access clock
> +            - description: Video clock
> +        clock-names:
> +          items:
> +            - const: aclk
> +            - const: pclk
> +            - const: vclk
> +      required:
> +        - clock-names
> +    else:
> +      properties:
> +        clocks:
> +          maxItems: 1
> +        clock-names: false
> +
>  examples:
>    # R8A7795 (R-Car H3) FCP for VSP-D1
>    - |
> --
> 2.25.1