Re: [PATCH V2 1/2] usb: gadget: u_ether: Improve print in gether_setup_name_default()
From: Andrzej Pietrasiewicz
Date: Tue Jan 17 2023 - 09:12:15 EST
W dniu 16.01.2023 o 16:55, Jon Hunter pisze:
The print in in gether_setup_name_default() does not provide any useful
information because a random MAC address will always be generated when
calling this function. Rather than removing the print, update the print
to show MAC address that is generated which is similar to other ethernet
drivers.
I'd say the above part is redundant. It is supposed to be a message understood
by future readers of the commit log, who will not necessarily know that we
were considering a complete removal of these messages.
Finally, given that the strings 'self' and 'host' are static we do not
need to pass these strings as an arguments.
Just drop the "Finally, ", the indefinite article "an" before the plural noun
"arguments" and the above sentence will accurately describe what the patch is
about.
With that
Reviewed-by: Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxxxx>
Signed-off-by: Jon Hunter <jonathanh@xxxxxxxxxx>
---
V1 -> V2: Added this patch
drivers/usb/gadget/function/u_ether.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/function/u_ether.c b/drivers/usb/gadget/function/u_ether.c
index 8f12f3f8f6ee..be8e7b448933 100644
--- a/drivers/usb/gadget/function/u_ether.c
+++ b/drivers/usb/gadget/function/u_ether.c
@@ -845,13 +845,13 @@ struct net_device *gether_setup_name_default(const char *netname)
snprintf(net->name, sizeof(net->name), "%s%%d", netname);
eth_random_addr(dev->dev_mac);
- pr_warn("using random %s ethernet address\n", "self");
+ pr_warn("using random self ethernet address %pM\n", dev->dev_mac);
/* by default we always have a random MAC address */
net->addr_assign_type = NET_ADDR_RANDOM;
eth_random_addr(dev->host_mac);
- pr_warn("using random %s ethernet address\n", "host");
+ pr_warn("using random host ethernet address %pM\n", dev->host_mac);
net->netdev_ops = ð_netdev_ops;