Re: [PATCH v3 2/4] powercap: idle_inject: Add update callback

From: Rafael J. Wysocki
Date: Tue Jan 17 2023 - 10:10:28 EST


On Tue, Jan 17, 2023 at 4:08 PM srinivas pandruvada
<srinivas.pandruvada@xxxxxxxxxxxxxxx> wrote:
>
> On Tue, 2023-01-17 at 12:13 +0100, Daniel Lezcano wrote:
> > On 17/01/2023 03:07, Srinivas Pandruvada wrote:
> >
> > [ ... ]
> >
> > > +struct idle_inject_device *idle_inject_register(struct cpumask
> > > *cpumask)
> > > +{
> > > + return idle_inject_register_full(cpumask, NULL);
> > > +}
> > > EXPORT_SYMBOL_NS_GPL(idle_inject_register, IDLE_INJECT);
> >
> > Why not just add the parameter to idle_inject_register() ?
> >
> > There is only one user ATM
> That was done in v1. But Rafael suggested to avoid changes to existing
> kernel source.

However, it can be done if Daniel prefers that. It is 1 callback now
only, so no big deal I suppose.