Re: [PATCH 20/20] staging: r8188eu: we use a constant number of hw_xmit entries
From: Greg Kroah-Hartman
Date: Tue Jan 17 2023 - 14:32:51 EST
On Fri, Dec 30, 2022 at 07:06:46PM +0100, Martin Kaiser wrote:
> struct xmit_priv contains a pointer to an array of struct hw_xmit entries.
> xmit_priv's (ill-named) hwxmit_entry component stores the size of this
> array, i.e. the number of hw_xmit entries that are used.
>
> The array size is constant, it's initialised to HWXMIT_ENTRY and never
> updated. Simplify the code accordingly. Remove hwxmit_entry, do not pass
> the array size as a function parameter and use HWXMIT_ENTRY in the code
> that handles the array.
>
> Signed-off-by: Martin Kaiser <martin@xxxxxxxxx>
> ---
> drivers/staging/r8188eu/core/rtw_xmit.c | 8 +++-----
> drivers/staging/r8188eu/hal/rtl8188eu_xmit.c | 2 +-
> drivers/staging/r8188eu/include/rtw_xmit.h | 3 +--
> 3 files changed, 5 insertions(+), 8 deletions(-)
This commit did not apply to my tree :(
thanks,
greg k-h