Re: [PATCH net-next 2/6] net: mdio: Rework scanning of bus ready for quirks

From: Jakub Kicinski
Date: Tue Jan 17 2023 - 20:21:10 EST


On Mon, 16 Jan 2023 13:55:14 +0100 Michael Walle wrote:
> From: Andrew Lunn <andrew@xxxxxxx>
>
> Some C22 PHYs do bad things when there are C45 transactions on the
> bus. In order to handle this, the bus needs to be scanned first for
> C22 at all addresses, and then C45 scanned for all addresses.
>
> The Marvell pxa168 driver scans a specific address on the bus to find
> its PHY. This is a C22 only device, so update it to use the c22
> helper.

clang says:

drivers/net/phy/mdio_bus.c:708:11: warning: variable 'i' is uninitialized when used here [-Wuninitialized]
while (--i >= 0) {
^
drivers/net/phy/mdio_bus.c:620:7: note: initialize the variable 'i' to silence this warning
int i, err;
^
= 0