Re: [PATCH] firmware: zynqmp: fix declarations for gcc-13

From: Michal Simek
Date: Wed Jan 18 2023 - 03:09:42 EST




On 1/18/23 08:31, Arnd Bergmann wrote:
On Wed, Jan 18, 2023, at 08:29, Michal Simek wrote:
On 1/17/23 21:03, Arnd Bergmann wrote:

On Tue, Jan 17, 2023, at 20:53, Tanmay Shah wrote:
This looks good to me. Thanks for fixing this.

Something must have gone wrong when I ran sparse check on this patch.

I don't think any of our previous tooling caught this, only gcc-13
changed some of the behavior around enums.

Just one question, does this patch need "fixes:" tag?

Probably a good idea:

Fixes: a5e56980cfb7 ("firmware: xilinx: Add RPU configuration APIs")

I can apply this directly to the soc fixes branch if you like
and add that line.

I have other patches in my soc branch to send you too.
Around next week I will be sending PR for it.
I can include this one too but up2you.

Since this is required for building with the latest compiler
I think we want this in 6.2 and backported to stable kernels
quickly. I'm about to send a fixes pull request for 6.2, so I'll
just include it here.

ok. Deal.

Acked-by: Michal Simek <michal.simek@xxxxxxx>

Thanks,
Michal