Re: [RESEND v3 01/13] dt-binding: mediatek: add bindings for MediaTek mt8195 MDP3 components

[Moudy Ho (何宗原)]

On Mon, 2023-01-16 at 09:10 +0100, Krzysztof Kozlowski wrote:
> On 16/01/2023 04:21, Moudy Ho wrote:

(snip)

> > +  mediatek,gce-client-reg:
> > +    description:
> > +      The register of client driver can be configured by gce with
> > 4 arguments
> > +      defined in this property, such as phandle of gce, subsys id,
> > +      register offset and size.
> > +      Each subsys id is mapping to a base address of display
> > function blocks
> > +      register which is defined in the gce header
> > +      include/dt-bindings/gce/<chip>-gce.h.
> > +    $ref: /schemas/types.yaml#/definitions/phandle-array
> > +    maxItems: 1
> 
> items with items syntax instead:
> 
> 
https://urldefense.com/v3/__https://elixir.bootlin.com/linux/v5.18-rc1/source/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml*L42__;Iw!!CTRNKA9wMg0ARbw!lcferrFFP-mshDHNL-rwJLgNKDrXF9fXoljpqL30k5YKTNvCwuC3webzR32VnQQoPeFvSvAewNkeupcT4mjdE_roxWUo$ ;
>  
> 
> > +

(snip)

> > +
> > +  mediatek,gce-client-reg:
> > +    description:
> > +      The register of client driver can be configured by gce with
> > 4 arguments
> > +      defined in this property, such as phandle of gce, subsys id,
> > +      register offset and size.
> > +      Each subsys id is mapping to a base address of display
> > function blocks
> > +      register which is defined in the gce header
> > +      include/dt-bindings/gce/<chip>-gce.h.
> 
> Full, real path please, so it could be validated with tools.
> 
> 
> Best regards,
> Krzysztof
> 

Hi Krzysztof,

Sorry to bug you again about this property, could it be changed to
following form.

    mediatek,gce-client-reg:
      $ref: /schemas/types.yaml#/definitions/phandle-array
      items:
        items:
          - description: phandle of GCE
          - description: GCE subsys id
          - description: register offset
          - description: register size
      description:
        ... defined in <include/dt-bindings/gce/mt8195-gce.h>.
     maxItems: 1 
  
Also, is the include header path still necessary in this form?

Sincerely,
Moudy