drivers/net/wireless/ath/ath11k/core.c:1309 ath11k_core_qmi_firmware_ready() warn: missing unwind goto?
From: Dan Carpenter
Date: Wed Jan 18 2023 - 04:43:28 EST
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: c1649ec55708ae42091a2f1bca1ab49ecd722d55
commit: 33b67a4b4e64275b6f2cbc4318f1596c70659111 ath11k: Update WBM idle ring HP after FW mode on
config: microblaze-randconfig-m041-20230116
compiler: microblaze-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Reported-by: Dan Carpenter <error27@xxxxxxxxx>
smatch warnings:
drivers/net/wireless/ath/ath11k/core.c:1309 ath11k_core_qmi_firmware_ready() warn: missing unwind goto?
vim +1309 drivers/net/wireless/ath/ath11k/core.c
d5c65159f28953 Kalle Valo 2019-11-23 1276 int ath11k_core_qmi_firmware_ready(struct ath11k_base *ab)
d5c65159f28953 Kalle Valo 2019-11-23 1277 {
d5c65159f28953 Kalle Valo 2019-11-23 1278 int ret;
d5c65159f28953 Kalle Valo 2019-11-23 1279
33b67a4b4e6427 Manikanta Pubbisetty 2022-04-06 1280 ret = ath11k_core_start_firmware(ab, ATH11K_FIRMWARE_MODE_NORMAL);
33b67a4b4e6427 Manikanta Pubbisetty 2022-04-06 1281 if (ret) {
33b67a4b4e6427 Manikanta Pubbisetty 2022-04-06 1282 ath11k_err(ab, "failed to start firmware: %d\n", ret);
33b67a4b4e6427 Manikanta Pubbisetty 2022-04-06 1283 return ret;
33b67a4b4e6427 Manikanta Pubbisetty 2022-04-06 1284 }
33b67a4b4e6427 Manikanta Pubbisetty 2022-04-06 1285
d5c65159f28953 Kalle Valo 2019-11-23 1286 ret = ath11k_ce_init_pipes(ab);
d5c65159f28953 Kalle Valo 2019-11-23 1287 if (ret) {
d5c65159f28953 Kalle Valo 2019-11-23 1288 ath11k_err(ab, "failed to initialize CE: %d\n", ret);
33b67a4b4e6427 Manikanta Pubbisetty 2022-04-06 1289 goto err_firmware_stop;
d5c65159f28953 Kalle Valo 2019-11-23 1290 }
d5c65159f28953 Kalle Valo 2019-11-23 1291
d5c65159f28953 Kalle Valo 2019-11-23 1292 ret = ath11k_dp_alloc(ab);
d5c65159f28953 Kalle Valo 2019-11-23 1293 if (ret) {
d5c65159f28953 Kalle Valo 2019-11-23 1294 ath11k_err(ab, "failed to init DP: %d\n", ret);
33b67a4b4e6427 Manikanta Pubbisetty 2022-04-06 1295 goto err_firmware_stop;
d5c65159f28953 Kalle Valo 2019-11-23 1296 }
d5c65159f28953 Kalle Valo 2019-11-23 1297
aa2092a9bab3f8 Venkateswara Naralasetty 2020-09-08 1298 switch (ath11k_crypto_mode) {
aa2092a9bab3f8 Venkateswara Naralasetty 2020-09-08 1299 case ATH11K_CRYPT_MODE_SW:
aa2092a9bab3f8 Venkateswara Naralasetty 2020-09-08 1300 set_bit(ATH11K_FLAG_HW_CRYPTO_DISABLED, &ab->dev_flags);
aa2092a9bab3f8 Venkateswara Naralasetty 2020-09-08 1301 set_bit(ATH11K_FLAG_RAW_MODE, &ab->dev_flags);
aa2092a9bab3f8 Venkateswara Naralasetty 2020-09-08 1302 break;
aa2092a9bab3f8 Venkateswara Naralasetty 2020-09-08 1303 case ATH11K_CRYPT_MODE_HW:
aa2092a9bab3f8 Venkateswara Naralasetty 2020-09-08 1304 clear_bit(ATH11K_FLAG_HW_CRYPTO_DISABLED, &ab->dev_flags);
aa2092a9bab3f8 Venkateswara Naralasetty 2020-09-08 1305 clear_bit(ATH11K_FLAG_RAW_MODE, &ab->dev_flags);
aa2092a9bab3f8 Venkateswara Naralasetty 2020-09-08 1306 break;
aa2092a9bab3f8 Venkateswara Naralasetty 2020-09-08 1307 default:
aa2092a9bab3f8 Venkateswara Naralasetty 2020-09-08 1308 ath11k_info(ab, "invalid crypto_mode: %d\n", ath11k_crypto_mode);
aa2092a9bab3f8 Venkateswara Naralasetty 2020-09-08 @1309 return -EINVAL;
ret = -EINVAL;
mutex_lock(&ab->core_lock);
goto err_dp_free;
I generally like to do the unlock before the goto instead of inside
the cleanup block but I don't know if that's allowed here.
aa2092a9bab3f8 Venkateswara Naralasetty 2020-09-08 1310 }
aa2092a9bab3f8 Venkateswara Naralasetty 2020-09-08 1311
aa2092a9bab3f8 Venkateswara Naralasetty 2020-09-08 1312 if (ath11k_frame_mode == ATH11K_HW_TXRX_RAW)
aa2092a9bab3f8 Venkateswara Naralasetty 2020-09-08 1313 set_bit(ATH11K_FLAG_RAW_MODE, &ab->dev_flags);
aa2092a9bab3f8 Venkateswara Naralasetty 2020-09-08 1314
d5c65159f28953 Kalle Valo 2019-11-23 1315 mutex_lock(&ab->core_lock);
33b67a4b4e6427 Manikanta Pubbisetty 2022-04-06 1316 ret = ath11k_core_start(ab);
d5c65159f28953 Kalle Valo 2019-11-23 1317 if (ret) {
d5c65159f28953 Kalle Valo 2019-11-23 1318 ath11k_err(ab, "failed to start core: %d\n", ret);
d5c65159f28953 Kalle Valo 2019-11-23 1319 goto err_dp_free;
d5c65159f28953 Kalle Valo 2019-11-23 1320 }
d5c65159f28953 Kalle Valo 2019-11-23 1321
d5c65159f28953 Kalle Valo 2019-11-23 1322 ret = ath11k_core_pdev_create(ab);
d5c65159f28953 Kalle Valo 2019-11-23 1323 if (ret) {
d5c65159f28953 Kalle Valo 2019-11-23 1324 ath11k_err(ab, "failed to create pdev core: %d\n", ret);
d5c65159f28953 Kalle Valo 2019-11-23 1325 goto err_core_stop;
d5c65159f28953 Kalle Valo 2019-11-23 1326 }
31858805f91ac7 Govind Singh 2020-05-08 1327 ath11k_hif_irq_enable(ab);
ec038c6127fa77 Wen Gong 2021-12-20 1328
ec038c6127fa77 Wen Gong 2021-12-20 1329 ret = ath11k_core_rfkill_config(ab);
ec038c6127fa77 Wen Gong 2021-12-20 1330 if (ret && ret != -EOPNOTSUPP) {
ec038c6127fa77 Wen Gong 2021-12-20 1331 ath11k_err(ab, "failed to config rfkill: %d\n", ret);
ec038c6127fa77 Wen Gong 2021-12-20 1332 goto err_core_stop;
ec038c6127fa77 Wen Gong 2021-12-20 1333 }
ec038c6127fa77 Wen Gong 2021-12-20 1334
d5c65159f28953 Kalle Valo 2019-11-23 1335 mutex_unlock(&ab->core_lock);
d5c65159f28953 Kalle Valo 2019-11-23 1336
d5c65159f28953 Kalle Valo 2019-11-23 1337 return 0;
d5c65159f28953 Kalle Valo 2019-11-23 1338
d5c65159f28953 Kalle Valo 2019-11-23 1339 err_core_stop:
d5c65159f28953 Kalle Valo 2019-11-23 1340 ath11k_core_stop(ab);
0366f42640a410 Vasanthakumar Thiagarajan 2019-11-28 1341 ath11k_mac_destroy(ab);
d5c65159f28953 Kalle Valo 2019-11-23 1342 err_dp_free:
d5c65159f28953 Kalle Valo 2019-11-23 1343 ath11k_dp_free(ab);
ba47923974fb67 Govindaraj Saminathan 2019-11-27 1344 mutex_unlock(&ab->core_lock);
33b67a4b4e6427 Manikanta Pubbisetty 2022-04-06 1345 err_firmware_stop:
33b67a4b4e6427 Manikanta Pubbisetty 2022-04-06 1346 ath11k_qmi_firmware_stop(ab);
33b67a4b4e6427 Manikanta Pubbisetty 2022-04-06 1347
d5c65159f28953 Kalle Valo 2019-11-23 1348 return ret;
d5c65159f28953 Kalle Valo 2019-11-23 1349 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests