Re: [PATCH v1 1/1] iio: adc: qcom-spmi-adc5: Fix the channel name

From: Marijn Suijten
Date: Wed Jan 18 2023 - 05:26:29 EST


On 2023-01-18 09:46:14, Andy Shevchenko wrote:
> On Wed, Jan 18, 2023 at 12:12:04AM +0100, Marijn Suijten wrote:
> > On 2023-01-17 11:39:44, Andy Shevchenko wrote:
> > > The node name can contain an address part which is not used by
> > > the driver. Cut it out before assigning the channel name.
> >
> > This explanation doesn't cut it. It's not that the driver "doesn't use"
>
> Driver doesn't use it still. There is no contradiction, but I agree that
> below part is good to have in the commit message.

You can leave that in if you want but that's not the issue that I
reported/described. Having both describes the situation in full.

> > the address part, it is that this string is propagated into the
> > userspace label, sysfs /filenames/ *and breaking ABI*.
>
> So I will add it into v2 in case the fix works (see below).
>
> ...
>
> > > - const char *name = fwnode_get_name(fwnode), *channel_name;
> > > + const char *name, *channel_name;
> >
> > I don't think this'll compile as name is still a pointer to const data,
> > while you're assigning (a '\0' char) to it below.
>
> Right, it's always hard for me to compile things for ARM on x86 :-)
> Thanks for catching this up!

Thanks for sending this in regardless; as said before I rather break ABI
and clean the driver up properly (no more extend_name...) than sending a
fix like this :)

> But does this fix the issue after compilation fix?

It does, no more @xx in sysfs filenames nor label contents!

- Marijn