Re: [PATCH v3 8/9] interconnect: qcom: rpm: Add a way to always set QoS registers

[Konrad Dybcio]

On 17.01.2023 14:27, Bryan O'Donoghue wrote:
> On 16/01/2023 13:21, Konrad Dybcio wrote:
>> On newer SoCs (there's no clear boundary, but probably "new enough"
>> means every interconnect provider is either BIMC or QNoC and there
>> are no old-style NoC hosts) we're expected to set QoS registers
>> regardless of the ap_owned param. Add a bool in the qcom_icc_provider
>> and make the logic assume it's okay to set the registers when it's
>> set.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
>> ---
>>   drivers/interconnect/qcom/icc-rpm.c | 2 +-
>>   drivers/interconnect/qcom/icc-rpm.h | 2 ++
>>   2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qcom/icc-rpm.c
>> index 509cadf398e9..343e6021a93a 100644
> 
> On next-20230116,
g fetch linux-next next-20230116
gco FETCH_HEAD
b4 am 20230116132152.405535-1-konrad.dybcio@xxxxxxxxxx
g am ./v3_20230116_konrad_dybcio_the_great_interconnecification_fixation.mbx

Stosowanie: interconnect: qcom: rpm: make QoS INVALID default, separate out driver data
Stosowanie: interconnect: qcom: rpm: Always set QoS params on QNoC
Stosowanie: interconnect: qcom: rpm: Add support for specifying channel num
Stosowanie: interconnect: qcom: Sort kerneldoc entries
Stosowanie: interconnect: qcom: rpm: Rename icc desc clocks to bus_blocks
Stosowanie: interconnect: qcom: rpm: Rename icc provider num_clocks to num_bus_clocks
Stosowanie: interconnect: qcom: rpm: Handle interface clocks
Stosowanie: interconnect: qcom: rpm: Add a way to always set QoS registers
Stosowanie: interconnect: qcom: rpm: Don't use clk_get_optional for bus clocks anymore
(no errors)

Konrad
> 
> git am < ~/Downloads/v3-1-9-interconnect-qcom-rpm-make-QoS-INVALID-default-separate-out-driver-data.patch
> Applying: interconnect: qcom: rpm: make QoS INVALID default, separate out driver data
> Applying: interconnect: qcom: rpm: Add support for specifying channel num
> Applying: interconnect: qcom: rpm: Rename icc desc clocks to bus_blocks
> Applying: interconnect: qcom: rpm: Add a way to always set QoS registers
> 
> error: patch failed: drivers/interconnect/qcom/icc-rpm.c:243
> error: drivers/interconnect/qcom/icc-rpm.c: patch does not apply
> error: patch failed: drivers/interconnect/qcom/icc-rpm.h:28
> error: drivers/interconnect/qcom/icc-rpm.h: patch does not apply
> Patch failed at 0004 interconnect: qcom: rpm: Add a way to always set QoS registers
> hint: Use 'git am --show-current-patch=diff' to see the failed patch
> 
> Should I pick up another series from elsewhere to apply this ?
> 
> ---
> bod