Quoting Srinivasa Rao Mandadapu (2023-01-11 23:53:23)Legacy path nodes are for ADSP bypass use case such as nodes lpass_audiocc, lpass_core, etc.
On 1/12/2023 2:54 AM, Stephen Boyd wrote:What is legacy path nodes?
Thanks for your time Stephen!!!
Quoting Srinivasa Rao Mandadapu (2023-01-04 08:21:37)As explained in previous versions, legacy path nodes are not being used
diff --git a/drivers/clk/qcom/lpasscc-sc7280.c b/drivers/clk/qcom/lpasscc-sc7280.cWhy are we adding these resets again? These are already exposed in
index 85dd5b9..1efb72d 100644
--- a/drivers/clk/qcom/lpasscc-sc7280.c
+++ b/drivers/clk/qcom/lpasscc-sc7280.c
@@ -102,6 +104,18 @@ static const struct qcom_cc_desc lpass_qdsp6ss_sc7280_desc = {
.num_clks = ARRAY_SIZE(lpass_qdsp6ss_sc7280_clocks),
};
+static const struct qcom_reset_map lpass_cc_sc7280_resets[] = {
+ [LPASS_AUDIO_SWR_RX_CGCR] = { 0xa0, 1 },
+ [LPASS_AUDIO_SWR_TX_CGCR] = { 0xa8, 1 },
+ [LPASS_AUDIO_SWR_WSA_CGCR] = { 0xb0, 1 },
lpassaudiocc-sc7280.c
in ADSP based platforms, due to conflicts.
Hence lpasscc node alone being used exclusively in ADSP based solution,I think I understand..
resets are added.
In probe also, these reset controls are enabled based onbut now I'm super confused! Please help me! We shouldn't have two
"qcom,adsp-pil-mode" property.
different device nodes for the same physical hardware registers.
Instead, we should have one node. The "qcom,adsp-pil-mode" property was
supposed to indicate the different mode of operation.
Maybe the audio clk and reset drivers on sc7280 are duplicating each
other and one of them can be removed?