Re: [PATCH v2 1/8] arm64: dts: qcom: sc7280: Extract audio nodes from common idp dtsi file

[Srinivasa Rao Mandadapu]

On 1/10/2023 4:27 PM, Krzysztof Kozlowski wrote:
Thanks for your time Krzysztof!!!
> On 05/01/2023 14:37, Srinivasa Rao Mandadapu wrote:
> > Split common idp dtsi file into audio specific dtsi and common
> > idp dtsi file.
> >
> > It is required to isolate idp and crd-rev3 platform device tree nodes
> > and convert crd-rev3 platform device tree nodes into audioreach specific
> > device tree nodes.
> >
> > Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@xxxxxxxxxxx>
> > Tested-by: Mohammad Rafi Shaik <quic_mohs@xxxxxxxxxxx>
> > ---
> Please include a changelog - either per patch or in cover letter.
Okay. Will include and re post it.
> >   arch/arm64/boot/dts/qcom/sc7280-audio-idp.dtsi | 135 +++++++++++++++++++++++++
> >   arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts     |   1 +
> >   arch/arm64/boot/dts/qcom/sc7280-idp.dtsi       | 126 -----------------------
> >   3 files changed, 136 insertions(+), 126 deletions(-)
> >   create mode 100644 arch/arm64/boot/dts/qcom/sc7280-audio-idp.dtsi
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7280-audio-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-audio-idp.dtsi
> > new file mode 100644
> > index 0000000..d1aea28
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/sc7280-audio-idp.dtsi
> > @@ -0,0 +1,135 @@
> > +// SPDX-License-Identifier: BSD-3-Clause
> > +/*
> > + * sc7280 Audio IDP board device tree source (common between SKU1 and SKU2)
> > + *
> > + * Copyright (c) 2022, The Linux Foundation. All rights reserved.
> > + */
> > +
> > +/{
> > +   /* BOARD-SPECIFIC TOP LEVEL NODES */
> Still wrong indentation.
Okay. Will fix it.
> > +	sound: sound {
> > +		compatible = "google,sc7280-herobrine";
> > +		model = "sc7280-wcd938x-max98360a-1mic";
> > +
>
>
>
> Best regards,
> Krzysztof